Updating Dockerfile to build the app from the ground up #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the Dockerfiles that I used for the documentation here: https://hub.docker.com/repository/docker/hapiproject/hapi
They're also the same Dockerfiles I'm using in my own environment to build and deploy HAPI. They're pretty flexible files, and perform the compile directly in docker, rather than requiring the user to compile the application first and then build the docker image. The advantage to this, is that the docker image is an exact representation of stuff on github, rather than potentially having custom from the machine running the docker build.