Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Java Minimum version to 17 #686

Merged
merged 2 commits into from
May 24, 2024
Merged

Updated Java Minimum version to 17 #686

merged 2 commits into from
May 24, 2024

Conversation

madduci
Copy link
Contributor

@madduci madduci commented May 24, 2024

Resolves issue #669

As for SpringBoot 3.2.x, the minimum Java Version must be 17.

Docker base images have been updated to newer versions.

Copy link
Collaborator

@jkiddo jkiddo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall - looks fine and safe since HAPI FHIR uses Spring Boot v3.2 declared here: https://github.com/hapifhir/hapi-fhir/blob/0fe3380c4a613fcb5c4af99a228bfcc7971f162a/pom.xml#L1013

It does also requires a bump on tomcat here:

FROM bitnami/tomcat:9.0 AS tomcat
due to https://spring.io/blog/2022/11/16/spring-framework-6-0-goes-ga

@jkiddo
Copy link
Collaborator

jkiddo commented May 24, 2024

@jamesagnew I imagine you would have an opinion on the timing of this?

@madduci
Copy link
Contributor Author

madduci commented May 24, 2024

I have a question about it. Should we swap the Tomcat image against e.g. Eclipse-Temurin base image? It comes also with a shell for debugging purposes and can run the SpringBoot package like the distroless one (also the Alpine one)

From one side it's more resilient compared to the one of Tomcat, maybe also smaller. On the other side, Tomcat should be tested separately, but for Production use in environments such as Kubernetes, I see that smaller attack surfaces are better.

@jkiddo
Copy link
Collaborator

jkiddo commented May 24, 2024

Main reason for having tomcat was to be sure that the application was compatible with tomcat. I dont know who uses the dockerized version of the application inside tomcat inside Docker.

@madduci madduci requested a review from jkiddo May 24, 2024 18:52
@jkiddo jkiddo merged commit f971db6 into hapifhir:master May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants