Upgrade to hapi-fhir 6.3.6-SNAPSHOT: Alternative solution. #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lukedegruchy
commented
Jan 10, 2023
•
lukedegruchy
commented
- Spawned from the crude and messy but effective solution in 480
- Remove static code blocks to Application.java and all tests:
- Downgrade logback.core to 1.2.11
- Downgrade logback.classic to 1.2.11
- Downgrade slf4j-api to 1.7.25 >>>>> This is the key difference missing from the first attempt that disabled logging.
- Add a new test config: JpaStarterWebsocketDispatcherConfig, and add it to @SpringBootTest for all of the ITs: This solves the NPE on jetty websocket tests that was introduced by the above changes. >>>> Jetty10RequestUpgradeStrategy.upgrade(Jetty10RequestUpgradeStrategy.java:124). >>> Cannot invoke "Object.getClass()" because "obj" is null
…code blocks to Application.java as well as all tests to System.setProperty("org.springframework.boot.logging.LoggingSystem", "none");
…ir-6-3-6-snapshot-with-logs-working
…ging, rollback slf4j-api, logback-classic, and logback-core to older versions. It's the addition of the rollback for slf4j-api that seems to restore logging.
…ir-6-3-6-snapshot-with-logs-working-downgrade-logback-solution
markiantorno
approved these changes
Jan 13, 2023
markiantorno
deleted the
ld-20230110-hapi-fhir-6-3-6-snapshot-with-logs-working-downgrade-logback-solution
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.