Cors fix #45
Merged
Cors fix #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesagnew
approved these changes
Aug 7, 2019
|
@jamesagnew would love to merge, but i still don't have contributor rights on this repo. |
|
@patrick-werner - Can you check the email account you have registered with GitHub? You should see an invite. |
|
@jamesagnew |
|
Can you try again? I'm still learning how permissions work in GitHub after all these years apparently :p |
|
it worked. Thanks @jamesagnew |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using cors.allowed.origin=* together with credentials is forbidden:
https://developer.mozilla.org/en-US/docs/Web/HTTP/Server-Side_Access_Control
https://www.w3.org/TR/cors/
and results in a 403 response.
This PR adds support for allowCredentials, and a list of allowed origins.
The spring CORS filter will check if the origin is in this list an returns the appropriate url.