Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building app in docker. Easier to override config file from /hapi-con… #42

Merged
merged 1 commit into from
Oct 1, 2019
Merged

Building app in docker. Easier to override config file from /hapi-con… #42

merged 1 commit into from
Oct 1, 2019

Conversation

seanmcilvenna
Copy link
Collaborator

…fig/hapi.properties

@seanmcilvenna
Copy link
Collaborator Author

I think this is actually very similar to #36
I didn't realize #36 existed. But, I think it may be a little better because of the abstraction of the config file, which can be overridden when running the docker image.

@seanmcilvenna seanmcilvenna mentioned this pull request Aug 2, 2019
Closed
@jamesagnew jamesagnew merged commit 7e1cd2c into master Oct 1, 2019
@jamesagnew jamesagnew deleted the docker-build branch October 1, 2019 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesagnew jamesagnew jamesagnew approved these changes

Assignees

@jamesagnew jamesagnew

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@seanmcilvenna @jamesagnew