Spring batch job enabled

[psavva]

This PR will remove the need to run -Dspring.batch.job.enabled=false and similar when running the hapi fhir jpa server before a few days ago.

Benefits: Avoid changing build process, and adding command line built parameters when it's not needed

Changes, defaulted the spring batch job enabled to false in application.yaml

[psavva]

@jamesagnew could you please review this PR as the recent changes to the implementation requires a change to the building process when it can be avoided

[jamesagnew]

What is the root cause here?

We shouldn't be disabling the batch job processor, it is needed in order to run batch jobs... HAPI won't work properly without it.

[jamesagnew]

@jvitrifork I assume this instruction was added when the boot stuff was added?

[psavva]

The current instructions is to disable it.
Please see https://github.com/hapifhir/hapi-fhir-jpaserver-starter/blob/master/README.md#using-jetty

If it's to be enabled by default, then more parameters are missing. Please see #136

Caused by: org.springframework.batch.core.JobParametersInvalidException: There must be a valid number for readChunkSize, which is at least 1. You must include [resourceTypes] as a Job Parameter

[jamesagnew]

Why is this instruction needed though? We weren't recommending that people disable the job executor 2 weeks ago, and we make basic assumptions in hapi JPA that it is running.

Making it easier to disable the executor is a band aid that will just make people have more subtle problems.

@seanmcilvenna this should be reverted IMO. We need to address the root cause.

[tadgh]

Just wanted to chime in here, this toggle, spring.batch.job.enabled=false is a specific boot setting to prevent ALL jobs from being run on boot, which for some reason, is SpringBoot's autoconfiguration default. https://docs.spring.io/spring-boot/docs/current/api/org/springframework/boot/autoconfigure/batch/BatchAutoConfiguration.html

[tadgh]

I don't think this disables batch itself, just the spring-boot magic of auto-running all configured jobs at context boot time.

Edit: As an aside, what a terrible name for a property, because it does read as though it is literally disabling all of spring batch

[seanmcilvenna]

@jamesagnew I have reverted... but I can definitely attest that I was not able to run hapi-fhir-jpaserver-starter without disabling spring.batch.job.enabled as well. The build is basically broken without this. So, I wonder if maybe it would be better to leave the PR merged, but create another PR that fixes the underlying issue and removes the spring.batch.job.enabled=false stuff...???

[jamesagnew]

Sorry - Given @tadgh it seems like I may have misunderstood what that setting was doing.

If it isn't actually disabling the batch processing, making it the default seems ok

[seanmcilvenna]

Ok. I'll revert my revert. LoL

[seanmcilvenna]

Ok phew there was nothing to revert. "master" is still good, and has this changed merged into it.

[jvitrifork]

A little late to the party here I guess. I agree with @tadgh - this is a trigger on the Spring Boot AutoConfiguration part. Until the design or the proper Bean definitions as the required Batch job configurations are changed in HAPI FHIR, or added to this project, the default should be to disable spring.batch.job - and I agree that adding this to the yml file is the way to go (wonder why I didn't do this myself?). The thing that now makes me think, is that this setting is now crucial in the yml file as the server in its current state will not start up if this is set to true - just as crucial as having the right db address and so on

[jvitrifork]

Perhaps a line of doc in the config file would be proper to add