Docs of hapi-fhir-testpage-overlay not loading properly due to local conformance statement issue #12
Conversation
jjcosare
commented
Feb 20, 2019
jjcosare
commented
- fixed issue on local conformance statement not loading properly
|
Why do you say it's not loading propertly? I run it as an "Application" using the ExampleServerDstu3IT class as the startup/main class within IntelliJ with the default settings without a prob... Are you running this via Jetty? or via Tomcat? |
- removed .keep_hapi-fhir-jpaserver-starter file as its not needed anymore
Running it via jetty based on docs |
…fuseToFetchThirdPartyUrls - updated fhir version to R4 and used mysql as datasource with docs updated - transferred jetty plugin to be viewable on intellij - disabled oss snapshots - replaced corsFilter based on new hapi docs
# Conflicts: # src/main/java/ca/uhn/fhir/jpa/starter/JpaRestfulServer.java # src/main/resources/hapi.properties # src/test/java/ca/uhn/fhir/jpa/starter/ExampleServerR4IT.java
# Conflicts: # src/main/java/ca/uhn/fhir/jpa/starter/JpaRestfulServer.java # src/main/resources/hapi.properties # src/test/java/ca/uhn/fhir/jpa/starter/ExampleServerR4IT.java
| // Define your CORS configuration. This is an example | ||
| // showing a typical setup. You should customize this | ||
| // to your specific needs | ||
| CorsConfiguration config = new CorsConfiguration(); |
There was a problem hiding this comment.
It'd probably make sense for this to be exposed in the HapiProperties file as a config item (maybe with the allowed origins being modifiable?)
There was a problem hiding this comment.
Thank you, have updated it to be configurable based on your suggestion. Also removed the unused lib on pom.xml and cors configuration on web.xml.
src/main/resources/hapi.properties
Outdated
| datasource.url=jdbc:derby:directory:target/jpaserver_derby_files;create=true | ||
| datasource.username= | ||
| datasource.password= | ||
| datasource.driver=com.mysql.cj.jdbc.Driver |
There was a problem hiding this comment.
I would rather leave the default configuration using Derby since that will work for anyone regardless of what other software they have installed.
There was a problem hiding this comment.
Noted, have reverted back to derby and instead added some updates on readme regarding mysql usage.
…s:https://github.com/hapifhir/hapi-fhir-jpaserver-starter/pull/12/files/6858c0d799ade820ab3d26b303a907cb0d6caec8#r266027967 - reverted mysql as default and used derby based on change request https://github.com/hapifhir/hapi-fhir-jpaserver-starter/pull/12/files/6858c0d799ade820ab3d26b303a907cb0d6caec8#r266028296 and updated readme to include specifics on configuring mysql - defaulted to jetty configs on hapi.properties so that this starter app will outright work without changing any configs with mvn jetty:run - updated subscription configs as it doesn't match already active subscription on subsequent runs using mysql as db - updated project based path resolution and removed unused file .keep_hapi-fhir-jpaserver-starter
… from "/hapi-fhir-jpaserver" to "/" and hapi.properties configs on server_address and server.base works out of the box with jetty - replicated testWebsocketSubscription test from ExampleServerR4IT into ExampleServerDstu3IT
- added favicon based on smiley on hapi logo
|
Looks great! Merging now. |
[permissions] search narrowing interceptor uses only active Practitio…
