Default url #11
Default url #11
Conversation
Fix for hapifhir#8. Default URLs should work now out of the box for jetty.
This reverts commit deeebb0.
Fix for hapifhir#8. Default URLs will now work out of the box with Jetty.
|
Looking at the failed travis CI build, it just dawned on me why we use the default values that we do... The application is intended to be able to be run on its own using Eclipse/IntelliJ as an "Application", with one of ExampleServerDstu3IT, ExampleServerDstu2IT, ExampleServerR4IT as the main class. In order to make this work with the tests, you would need to modify these test classes to run on the 8080 port, and the /hapi-fhir-jpaserver base url. |
hapifhir#8. use the original URLs, but add some commented out configs to help with Jetty
|
@seanmcilvenna - I just committed a change that keeps the old URLs, but just puts in a commented out hint version for Jetty. |
|
Chiming in a bit late... :) I wonder if it would make sense for us to modify the tests to also put the app at the same context root that Jetty does? This would mean one less thing to change in the file... |
|
I would agree with that change. Not sure I know enough about how the tests are built to make the change myself, though. Can investigate (at some point - no guarantee when, though). |
|
I'll have a look at some point.. I guess the other issue is that even with that change, we'd still have to account for the port being different. Something to figure out in the future.. :) |
Fix for #8. Fixing server_address and server.base so that the URLs will work out of the box with Jetty.