use images instead of image to match model.forward kwarg #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 27, 2023
choics2623
pushed a commit
to choics2623/LLaVA
that referenced
this pull request
Dec 16, 2023
…es-name-fix use images instead of image to match model.forward kwarg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the model's forward method expects
imagesas a keyword arg. This is getting set asimagecurrently and gets removed by HF's RemoveColumnsCollator sinceimageisn't a valid kwarg to pass to themodel.forward(...)RemoveColumnsCollator wraps the DataCollatorForSupervisedDataset, so even though DataCollatorForSupervisedDataset outputs an
imagesfeature,imagegets stripped before it ever makes it to the collator`