-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spring.sbp.custom-plugin-loaders and pluginRepository #13
Comments
Make sense. Have made custom-plugin-loader exclusive. I will think about refactoring |
not an easy work. pf4j is designed in old school OOP principal and make it kinds of hard to be extent and customized (comparing to IOC framework like spring). For example, to extend |
I've tried the prop in application-context
spring.sbp.custom-plugin-loaders
.It appends custom loaders to the list of pre-existing loaders. So custom loaders can't apply for files with extension .zip or .jar, because the loading is prevented by pre-existing loaders.
So the custom loader should apply for files with different extension, but it's not possible, because the file discovering is accomplished by
fileFilter
inPluginRepository
and there is no way to add custom pluginRepository.Could you allow to set plugin repositories as you done with plugin loaders?
Let me say my opinion: maybe It's too limited to customize the SpringBootPluginManager only through properties in application.yml. The force of pf4j is the high grade of customization by class inheritance. Why is it not possible to extend your SpringBootPluginManager and declare it as bean preventing the creation in the sbp library? after all there is a
@ConditionalOnMissingBean
inSbpAutoConfiguration
.The text was updated successfully, but these errors were encountered: