Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

Content api add method to get theme detail and settings by id #25

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Feb 18, 2022

  1. ThemeClient#getPropertyById
  2. ThemeClient#listSettingsById

#24 halo-dev/halo#1660

Signed-off-by: Ryan Wang [email protected]

@netlify
Copy link

netlify bot commented Feb 18, 2022

✔️ Deploy Preview for halo-js-sdk ready!

🔨 Explore the source changes: 76d6e30

🔍 Inspect the deploy log: https://app.netlify.com/sites/halo-js-sdk/deploys/620f2f81bc3ce00008489743

😎 Browse the preview: https://deploy-preview-25--halo-js-sdk.netlify.app/classes/_halo_dev_content_api.themeclient

@ruibaby ruibaby changed the title feat: content api add method to get theme detail and settings by id WIP:feat: content api add method to get theme detail and settings by id Feb 18, 2022
@ruibaby ruibaby changed the title WIP:feat: content api add method to get theme detail and settings by id WIP: feat: content api add method to get theme detail and settings by id Feb 18, 2022
@ruibaby ruibaby added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 18, 2022
@guqing guqing changed the title WIP: feat: content api add method to get theme detail and settings by id WIP: Content api add method to get theme detail and settings by id Feb 18, 2022
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can only merge it after upstream PR Halo#1660 merged

@ruibaby ruibaby merged commit 959ab52 into halo-dev:master Feb 18, 2022
@ruibaby ruibaby deleted the feat/add-get-theme-method branch February 18, 2022 06:09
@ruibaby ruibaby changed the title WIP: Content api add method to get theme detail and settings by id Content api add method to get theme detail and settings by id Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants