feat: add basic functions of demo mode #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruibaby
requested changes
Feb 14, 2020
src/main/java/run/halo/app/handler/aspect/DisableApiAspect.java
Outdated
Show resolved
Hide resolved
src/main/java/run/halo/app/controller/admin/api/UserController.java
Outdated
Show resolved
Hide resolved
ruibaby
requested changes
Feb 14, 2020
src/main/java/run/halo/app/handler/aspect/DisableApiAspect.java
Outdated
Show resolved
Hide resolved
Closed
|
建议写测试类 |
不知道怎么写这样的测试类（注解和切面） |
JohnNiang
requested changes
Feb 14, 2020
src/main/java/run/halo/app/handler/aspect/DisableApiAspect.java
Outdated
Show resolved
Hide resolved
src/main/java/run/halo/app/handler/aspect/DisableApiAspect.java
Outdated
Show resolved
Hide resolved
|
这个 |
|
@ruibaby 今天问你 你没回 然后就先用了这个名字 |
|
看起来差不多了，可以考虑合并了。 |
|
@JohnNiang 如果review没问题就可以合并了 |
JohnNiang
approved these changes
Feb 14, 2020
ruibaby
pushed a commit
to ruibaby/halo
that referenced
this pull request
Jun 11, 2021
* feat: add basic functions of demo mode * feat: add @disableApi annotation to some API that should be disabled * feat: add DisableApi test case * fix: change DisableApi annotation name to DisableOnConditation * Fix test cases * Add more strict test on failing case Co-authored-by: John Niang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.