-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: support extending jar directories for plugin class loader #3108
Conversation
我这里依然无法启动,日志:
|
dev profile 的 lib-directories 配置有点问题,我更新了,参考 de8489e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind improvement
/area core
/milestone 2.2.x
What this PR does / why we need it:
修复引入外部依赖的插件以开发模式启动时会出现 NoClassDefFoundError 的问题
see #3107 for more detail.
Which issue(s) this PR fixes:
Fixes #3107
Special notes for your reviewer:
how to test it?
以插件 development 模式启动以下两个插件观察是否正常启动:
期望没有
Caused by: java. lang. NoClassDefFoundEenon
错误,且插件正确启动。/cc @halo-dev/sig-halo
Does this PR introduce a user-facing change?