Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default theme cannot be initialized in the jar distribution #2991

Merged
merged 6 commits into from
Dec 19, 2022
Merged

fix: default theme cannot be initialized in the jar distribution #2991

merged 6 commits into from
Dec 19, 2022

Conversation

minliacom
Copy link
Contributor

@minliacom minliacom commented Dec 17, 2022 •
edited by JohnNiang
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

To fix that default earth theme file not found in system initialization.

Which issue(s) this PR fixes:

Fixes #2910

Special notes for your reviewer:

Does this PR introduce a user-facing change?

修复 Jar 包部署时无法初始化主题的问题

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Dec 17, 2022
@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 17, 2022
JohnNiang
JohnNiang reviewed Dec 19, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
JohnNiang
JohnNiang approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the following two scenarios:

  1. Run Halo with fat Jar
  2. Run Halo with Docker

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2022
@ruibaby ruibaby changed the title fix: default earth theme file not found in system initialization. fix: default theme cannot be initialized in the jar distribution Dec 19, 2022
ruibaby
ruibaby approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

image

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2022
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minliacom
Copy link
Contributor Author

/lgtm

image

去掉上面那个吧

@f2c-ci-robot f2c-ci-robot bot merged commit dee496b into halo-dev:main Dec 19, 2022
@ruibaby
Copy link
Member

ruibaby commented Dec 19, 2022

去掉上面那个吧

哪个？

@minliacom
Copy link
Contributor Author

哦哦 2条日志不同状态 留着也还可以

@ruibaby
Copy link
Member

ruibaby commented Dec 19, 2022

哦哦 2条日志不同状态 留着也还可以

嗯，我圈起来只是说明正常工作了。

@minliacom
Copy link
Contributor Author

嗯嗯

@JohnNiang JohnNiang added this to the 2.1.x milestone Dec 19, 2022
@JohnNiang
Copy link
Member

/cherrypick release-2.0

@halo-dev-bot halo-dev-bot mentioned this pull request Dec 19, 2022
Merged
@halo-dev-bot
Copy link
Collaborator

@JohnNiang: new pull request created: #3009

In response to this:

/cherrypick release-2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Dec 20, 2022
@halo-dev-bot
[release-2.0] fix: default theme cannot be initialized in the jar dis…
7adf98d 
…tribution (#3009)

This is an automated cherry-pick of #2991

/assign JohnNiang

```release-note
NONE
```
@JohnNiang JohnNiang modified the milestones: 2.1.x, 2.1.0 Dec 20, 2022
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnNiang JohnNiang JohnNiang approved these changes

@ruibaby ruibaby ruibaby approved these changes

@guqing guqing Awaiting requested review from guqing

Assignees

@ruibaby ruibaby

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

打包成jar后运行报错，读不到资源主题文件
4 participants
@minliacom @ruibaby @JohnNiang @halo-dev-bot