Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add @minliacom to reviewer list #2956

Merged
merged 2 commits into from
Dec 16, 2022
Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Dec 15, 2022

What type of PR is this?

/kind improvement

What this PR does / why we need it:

@minliacom 添加到 Reviewer 列表。

他的贡献列表:

欢迎 @minliacom 加入。

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note-none Denotes a PR that doesn't merit a release note. labels Dec 15, 2022
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Dec 15, 2022
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Dec 15, 2022
@guqing
Copy link
Member

guqing commented Dec 15, 2022

welcome @minliacom to join our list of reviewers! 🎉

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2022
@wan92hen
Copy link
Collaborator

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit c90f192 into main Dec 16, 2022
@JohnNiang JohnNiang deleted the add-minliacom-to-reviewer branch December 16, 2022 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants