Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: change the maximum limit of request body to 10MB #2936

Merged
merged 2 commits into from
Dec 13, 2022
Merged

perf: change the maximum limit of request body to 10MB #2936

merged 2 commits into from
Dec 13, 2022

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Dec 13, 2022

What type of PR is this?

/kind improvement

What this PR does / why we need it:

将 http 请求体的最大字节数改为 10m。

Ref #2861 (comment)

Which issue(s) this PR fixes:

Fixes #2861

Special notes for your reviewer:

测试方式：

  1. 在 Console 端新建文章，保存大量文本内容（最快方式是截图或者复制图片到编辑器，这时候因为会转为 base64，所以内容会很大）
  2. 保存文章，检查是否成功。

Does this PR introduce a user-facing change?

修改 HTTP 请求体最大字节数的限制，修复保存大内容文章异常的问题。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Dec 13, 2022
@JohnNiang JohnNiang changed the title perf: change the maximum number of bytes requested to 10m perf: change the maximum limit request body to 10m Dec 13, 2022
@JohnNiang JohnNiang changed the title perf: change the maximum limit request body to 10m perf: change the maximum limit of request body to 10MB Dec 13, 2022
JohnNiang
JohnNiang approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2022
guqing
guqing reviewed Dec 13, 2022
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit df0e6cf into halo-dev:main Dec 13, 2022
@ruibaby ruibaby deleted the perf/max-inmemory-size branch December 13, 2022 16:00
@ruibaby ruibaby mentioned this pull request Dec 14, 2022
Closed
@JohnNiang
Copy link
Member

/cherry-pick release-2.0

@halo-dev-bot halo-dev-bot mentioned this pull request Dec 19, 2022
Merged
@halo-dev-bot
Copy link
Collaborator

@JohnNiang: new pull request created: #3000

In response to this:

/cherry-pick release-2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Dec 19, 2022
@halo-dev-bot
[release-2.0] perf: change the maximum limit of request body to 10MB (#…
cf8e464 
…3000)

This is an automated cherry-pick of #2936

/assign JohnNiang

```release-note
修改 HTTP 请求体最大字节数的限制，修复保存大内容文章异常的问题。
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guqing guqing guqing left review comments

@JohnNiang JohnNiang JohnNiang approved these changes

@lan-yonghui lan-yonghui Awaiting requested review from lan-yonghui

Assignees

@guqing guqing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

无法保存大文本文章内容
4 participants
@ruibaby @JohnNiang @halo-dev-bot @guqing