Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update readme for Halo 2.0 #2492

Merged
merged 2 commits into from
Sep 30, 2022

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Sep 29, 2022

What type of PR is this?

/kind documentation
/milestone 2.0

What this PR does / why we need it:

更新 README。

See #2410 for more

Special notes for your reviewer:

/hold

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. labels Sep 29, 2022
@f2c-ci-robot f2c-ci-robot bot added this to the 2.0 milestone Sep 29, 2022
@f2c-ci-robot f2c-ci-robot bot added the kind/documentation Categorizes issue or PR as related to documentation. label Sep 29, 2022
@ruibaby
Copy link
Member Author

ruibaby commented Sep 29, 2022

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/unhold
/approve
/lgtm

@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2022
@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2022
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit 3b47035 into halo-dev:next Sep 30, 2022
@ruibaby ruibaby deleted the docs/readme-for-halo-2.0 branch October 1, 2022 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants