-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
插件提供的静态资源建议添加缓存标识 #3205
Comments
IMO,更倾向方案 2。这样既能缓存,也能在切换版本的时候忽略缓存。 |
@guqing 这个改动应该是不涉及到太多的业务,是否可以标记为 |
在以下部分设置两个链接时追加一个参数即可 halo/src/main/java/run/halo/app/core/extension/reconciler/PluginReconciler.java Lines 161 to 165 in 0fd023b
/kind good-first-issue |
@guqing: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/good-first-issue |
Duplicate #3137 |
/assign @guqing |
#### What type of PR is this? /kind improvement /area core /milestone 2.3.x #### What this PR does / why we need it: 对插件的静态资源(js, css) 增加 version 版本号,用于解决插件静态资源缓存的问题。另外同时也对插件 Logo 增加了版本号标识。 #### Which issue(s) this PR fixes: Fixes #3205 #### Special notes for your reviewer: 验证 Console 端插件静态资源链接是否携带 `version={pluginVersion}` 。 特别的,对于 logo只会增加相对路径下的地址,绝对路径的地址将直接返回原始路径/值。 #### Does this PR introduce a user-facing change? ```release-note 为插件静态资源路径增加版本标识以解决缓存更新不及时的问题 ```
你当前使用的版本
2.2.0
描述一下此特性
目前在 #3074 中对静态资源做了缓存策略的处理,但目前发现插件如果包含了静态资源,升级之后无法及时更新。
比如插件的静态资源为
/plugins/PluginLinks/assets/console/main.js
,在未来某个版本更新了这个资源,那么在用户升级插件的时候就无法获取到新的资源。目前设想的解决方案:
/kind improvement
/area core
附加信息
No response
The text was updated successfully, but these errors were encountered: