IRShow: simplify effectbits_[color|letter] implementations (JuliaLa…

…ng#46293)
halleysfifthinc · Aug 9, 2022 · f0baed2 · f0baed2
1 parent 5e081d6
commit f0baed2
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/base/compiler/ssair/show.jl b/base/compiler/ssair/show.jl
@@ -791,21 +791,27 @@ function show_ir(io::IO, code::Union{IRCode, CodeInfo}, config::IRShowConfig=def
 end
 
 function effectbits_letter(effects::Effects, name::Symbol, suffix::Char)
- if name === :consistent || name === :effect_free || name === :inaccessiblememonly
+ ft = fieldtype(Effects, name)
+ if ft === UInt8
  prefix = getfield(effects, name) === ALWAYS_TRUE ? '+' :
  getfield(effects, name) === ALWAYS_FALSE ? '!' : '?'
- else
+ elseif ft === Bool
  prefix = getfield(effects, name) ? '+' : '!'
+ else
+ error("unsupported effectbits type given")
  end
  return string(prefix, suffix)
 end
 
 function effectbits_color(effects::Effects, name::Symbol)
- if name === :consistent || name === :effect_free || name === :inaccessiblememonly
+ ft = fieldtype(Effects, name)
+ if ft === UInt8
  color = getfield(effects, name) === ALWAYS_TRUE ? :green :
  getfield(effects, name) === ALWAYS_FALSE ? :red : :yellow
- else
+ elseif ft === Bool
  color = getfield(effects, name) ? :green : :red
+ else
+ error("unsupported effectbits type given")
  end
  return color
 end