Skip to content

Commit

Permalink
remove dead comment (JuliaLang#46132)
Browse files Browse the repository at this point in the history
JuliaLang#45993 fixed this bug, let's make
the math effect-tests actually fail
  • Loading branch information
aviatesk committed Jul 23, 2022
1 parent c5a63d8 commit c32c0d2
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions test/math.jl
Original file line number Diff line number Diff line change
Expand Up @@ -1458,14 +1458,7 @@ for fn in (:sin, :cos, :tan, :log, :log2, :log10, :log1p, :exponent, :sqrt, :cbr
for T in (Float32, Float64)
f = getfield(@__MODULE__, fn)
eff = Base.infer_effects(f, (T,))
if Core.Compiler.is_foldable(eff)
@test true
else
# XXX only print bad effects – especially `[sin|cos|tan](::Float32)` are analyzed
# as non-foldable sometimes but non-deterministically somehow, we need to dig
# into what's leading to the bad analysis with Cthulhu on each platform
@warn "bad effects found for $f(::$T)" eff
end
@test Core.Compiler.is_foldable(eff)
end
end
for T in (Float32, Float64)
Expand Down

0 comments on commit c32c0d2

Please sign in to comment.