Fixed printing for Complex{Int} with maximum negative imaginary part …

…(Issue JuliaLang#33433) (JuliaLang#33498)
halleysfifthinc · Oct 9, 2019 · b75fce2 · b75fce2
1 parent e0bdc76
commit b75fce2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/base/complex.jl b/base/complex.jl
@@ -184,12 +184,16 @@ function show(io::IO, z::Complex)
  compact = get(io, :compact, false)
  show(io, r)
  if signbit(i) && !isnan(i)
- i = -i
  print(io, compact ? "-" : " - ")
+ if isa(i,Signed) && !isa(i,BigInt) && i == typemin(typeof(i))
+ show(io, -widen(i))
+ else
+ show(io, -i)
+ end
  else
  print(io, compact ? "+" : " + ")
+ show(io, i)
  end
- show(io, i)
  if !(isa(i,Integer) && !isa(i,Bool) || isa(i,AbstractFloat) && isfinite(i))
  print(io, "*")
  end

diff --git a/test/complex.jl b/test/complex.jl
@@ -14,6 +14,7 @@ end
 #show
 @test sprint(show, complex(1, 0), context=:compact => true) == "1+0im"
 @test sprint(show, complex(true, true)) == "Complex(true,true)"
+@test sprint(show, Complex{Int8}(0, typemin(Int8))) == "0 - 128im"
 
 @testset "unary operator on complex boolean" begin
  @test +Complex(true, true) === Complex(1, 1)