Compare Symbols and Chars more efficiently in Cholesky (JuliaLang#28873)

halleysfifthinc · Aug 26, 2018 · a2a1506 · a2a1506
1 parent 7314249
commit a2a1506
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/stdlib/LinearAlgebra/src/cholesky.jl b/stdlib/LinearAlgebra/src/cholesky.jl
@@ -340,11 +340,11 @@ function getproperty(C::Cholesky, d::Symbol)
  Cuplo = getfield(C, :uplo)
  info = getfield(C, :info)
  if d == :U
- return UpperTriangular(Symbol(Cuplo) == d ? Cfactors : copy(Cfactors'))
+ return UpperTriangular(Cuplo === char_uplo(d) ? Cfactors : copy(Cfactors'))
  elseif d == :L
- return LowerTriangular(Symbol(Cuplo) == d ? Cfactors : copy(Cfactors'))
+ return LowerTriangular(Cuplo === char_uplo(d) ? Cfactors : copy(Cfactors'))
  elseif d == :UL
- return (Symbol(Cuplo) == :U ? UpperTriangular(Cfactors) : LowerTriangular(Cfactors))
+ return (Cuplo === 'U' ? UpperTriangular(Cfactors) : LowerTriangular(Cfactors))
  else
  return getfield(C, d)
  end