Repair rand{T<:Integer}(r::Range1{T}) for signed types. Closes JuliaL…

…ang#3004.
halleysfifthinc · May 3, 2013 · 894c01a · 894c01a
1 parent 9a72fab
commit 894c01a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/base/random.jl b/base/random.jl
@@ -146,7 +146,7 @@ function rand{T<:Integer}(r::Range1{T})
  hi = r[end]
 
  m = typemax(T)
- s = abs(rand(T))
+ s = rand(T) & m
  if (hi-lo == m)
  return s + lo
  end
@@ -158,7 +158,7 @@ function rand{T<:Integer}(r::Range1{T})
  # note: m>=0 && r>=0
  lim = m - rem(rem(m,r)+1, r)
  while s > lim
- s = rand(T)
+ s = rand(T) & m
  end
  return rem(s,r) + lo
 end

diff --git a/test/random.jl b/test/random.jl
@@ -3,3 +3,4 @@
 @test rand(Uint32) >= 0
 @test -10 <= rand(-10:-5) <= -5
 @test -10 <= rand(-10:5) <= 5
+@test min([rand(int32(1):int32(7^7)) for i = 1:100000]) > 0