compiler: NFC changes

base/compiler/abstractinterpretation.jl

@@ -496,13 +496,13 @@ function abstract_call_method(interp::AbstractInterpreter, method::Method, @nosp
  add_remark!(interp, sv, "Refusing to infer into `depwarn`")
  return MethodCallResult(Any, false, false, nothing, Effects())
  end
- topmost = nothing
+
  # Limit argument type tuple growth of functions:
  # look through the parents list to see if there's a call to the same method
  # and from the same method.
  # Returns the topmost occurrence of that repeated edge.
- edgecycle = false
- edgelimited = false
+ edgecycle = edgelimited = false
+ topmost = nothing
 
  for infstate in InfStackUnwind(sv)
  if method === infstate.linfo.def

base/compiler/ssair/passes.jl

@@ -916,14 +916,11 @@ function sroa_pass!(ir::IRCode, inlining::Union{Nothing, InliningState} = nothin
  visited_phinodes, field, lifting_cache, result_t, lifted_leaves, val, lazydomtree)
 
  # Insert the undef check if necessary
- if any_undef
- if val === nothing
- insert_node!(compact, SSAValue(idx),
- non_effect_free(NewInstruction(Expr(:throw_undef_if_not, Symbol("##getfield##"), false), Nothing)))
- else
- # val must be defined
- end
+ if any_undef && val === nothing
+ insert_node!(compact, SSAValue(idx), non_effect_free(NewInstruction(
+ Expr(:throw_undef_if_not, Symbol("##getfield##"), false), Nothing)))
  else
+ # val must be defined
  @assert val !== nothing
  end
 

base/show.jl

@@ -1192,8 +1192,8 @@ function print_fullname(io::IO, m::Module)
  end
 end
 
-function sourceinfo_slotnames(src::CodeInfo)
- slotnames = src.slotnames
+sourceinfo_slotnames(src::CodeInfo) = sourceinfo_slotnames(src.slotnames)
+function sourceinfo_slotnames(slotnames::Vector{Symbol})
  names = Dict{String,Int}()
  printnames = Vector{String}(undef, length(slotnames))
  for i in eachindex(slotnames)