delete OldPkg (JuliaLang#27930)

.circleci/config.yml

@@ -59,7 +59,7 @@ jobs:
  pushd /tmp/julia/share/julia/test &&
  if [ $(echo "$FILES_CHANGED" | grep -cv '^doc/') -gt 0 ]; then
  /tmp/julia/bin/julia --check-bounds=yes runtests.jl all --skip Sockets | bar -i 30 &&
- /tmp/julia/bin/julia --check-bounds=yes runtests.jl LibGit2/online OldPkg/pkg Pkg/pkg download;
+ /tmp/julia/bin/julia --check-bounds=yes runtests.jl LibGit2/online Pkg/pkg download;
  fi &&
  popd &&
  mkdir /tmp/embedding-test &&

.freebsdci.sh

@@ -45,7 +45,7 @@ runtests(){
 
  ./usr/bin/julia --check-bounds=yes test/runtests.jl all
  ./usr/bin/julia --check-bounds=yes test/runtests.jl \
- LibGit2/online OldPkg/pkg Pkg/pkg download
+ LibGit2/online Pkg/pkg download
 }
 
 test-embedding(){

.travis.yml

@@ -134,7 +134,7 @@ script:
  # skip tests if only files within the "doc" dir have changed
  - if [ $(echo "$FILES_CHANGED" | grep -cv '^doc/') -gt 0 ]; then
  /tmp/julia/bin/julia --check-bounds=yes runtests.jl $TESTSTORUN &&
- /tmp/julia/bin/julia --check-bounds=yes runtests.jl LibGit2/online OldPkg/pkg Pkg/pkg download; fi
+ /tmp/julia/bin/julia --check-bounds=yes runtests.jl LibGit2/online Pkg/pkg download; fi
  - popd
  # test that the embedding code works on our installation
  - mkdir /tmp/embedding-test &&

appveyor.yml

@@ -63,6 +63,6 @@ test_script:
  - usr\bin\julia -e "Base.require(Main, :InteractiveUtils).versioninfo()"
  - usr\bin\julia --sysimage-native-code=no -e "true"
  - cd julia-* && .\bin\julia.exe --check-bounds=yes share\julia\test\runtests.jl all &&
- .\bin\julia.exe --check-bounds=yes share\julia\test\runtests.jl LibGit2/online OldPkg/pkg Pkg/pkg download
+ .\bin\julia.exe --check-bounds=yes share\julia\test\runtests.jl LibGit2/online Pkg/pkg download
  - cd ..
  - usr\bin\julia usr\share\julia\test\embedding\embedding-test.jl test\embedding\embedding.exe

base/sysimg.jl

@@ -515,7 +515,6 @@ let
  :Random,
  :UUIDs,
  :Future,
- :OldPkg,
  :LinearAlgebra,
  :SparseArrays,
  :SuiteSparse,

contrib/precompile_explicit.jl

@@ -451,7 +451,6 @@ precompile(Tuple{typeof(Base.show), Base.GenericIOBuffer{Array{UInt8, 1}}, UInt6
 precompile(Tuple{typeof(Base.show), Base.IOContext{Base.GenericIOBuffer{Array{UInt8, 1}}}, Array{Any, 1}})
 precompile(Tuple{typeof(Base.show), Base.IOContext{Base.GenericIOBuffer{Array{UInt8, 1}}}, Int64})
 precompile(Tuple{typeof(Base.show), Base.IOContext{Base.GenericIOBuffer{Array{UInt8, 1}}}, String})
-precompile(Tuple{typeof(Base.show), Base.IOContext{Base.GenericIOBuffer{Array{UInt8, 1}}}, typeof(OldPkg.dir)})
 precompile(Tuple{typeof(Base.show), Base.IOContext{REPL.Terminals.TTYTerminal}, Base.MIME{Symbol("text/plain")}, Array{Float64, 1}})
 precompile(Tuple{typeof(Base.show), Base.IOContext{REPL.Terminals.TTYTerminal}, Base.MIME{Symbol("text/plain")}, Array{Float64, 2}})
 precompile(Tuple{typeof(Base.show), Base.IOContext{REPL.Terminals.TTYTerminal}, Base.MIME{Symbol("text/plain")}, Array{Int64, 1}})
@@ -606,7 +605,6 @@ precompile(Tuple{typeof(Markdown.terminline), Base.IOContext{Base.GenericIOBuffe
 precompile(Tuple{typeof(Markdown.terminline), Base.IOContext{Base.GenericIOBuffer{Array{UInt8, 1}}}, String})
 precompile(Tuple{typeof(Markdown.terminline_string), Base.IOContext{Base.GenericIOBuffer{Array{UInt8, 1}}}, Array{Any, 1}})
 precompile(Tuple{typeof(Markdown.terminline_string), Base.IOContext{REPL.Terminals.TTYTerminal}, Array{Any, 1}})
-precompile(Tuple{typeof(OldPkg.dir)})
 precompile(Tuple{typeof(Pkg.REPLMode.create_mode), REPL.LineEditREPL, REPL.LineEdit.Prompt})
 precompile(Tuple{typeof(Pkg.REPLMode.repl_init), REPL.LineEditREPL})
 precompile(Tuple{typeof(REPL.LineEdit.accept_result), REPL.LineEdit.MIState, REPL.LineEdit.PrefixHistoryPrompt})

doc/src/manual/environment-variables.md

@@ -121,11 +121,6 @@ over `$EDITOR`. If none of these environment variables is set, then the editor
 is taken to be `open` on Windows and OS X, or `/etc/alternatives/editor` if it
 exists, or `emacs` otherwise.
 
-!!! note
-
- `$JULIA_EDITOR` is *not* used in the determination of the editor for
- `OldPkg.edit`: this function checks `$VISUAL` and `$EDITOR` alone.
-
 ## Parallelization
 
 ### `JULIA_CPU_THREADS`

stdlib/InteractiveUtils/test/runtests.jl

@@ -175,16 +175,12 @@ end
 # PR #23075
 @testset "versioninfo" begin
  # check that versioninfo(io; verbose=true) doesn't error, produces some output
- # and doesn't invoke OldPkg.status which will error if JULIA_PKGDIR is set
  mktempdir() do dir
- withenv("JULIA_PKGDIR" => dir) do
- buf = PipeBuffer()
- versioninfo(buf, verbose=true)
- ver = read(buf, String)
- @test startswith(ver, "Julia Version $VERSION")
- @test occursin("Environment:", ver)
- @test isempty(readdir(dir))
- end
+ buf = PipeBuffer()
+ versioninfo(buf, verbose=true)
+ ver = read(buf, String)
+ @test startswith(ver, "Julia Version $VERSION")
+ @test occursin("Environment:", ver)
  end
  let exename = `$(Base.julia_cmd()) --startup-file=no`
  @test !occursin("Environment:", read(setenv(`$exename -e 'using InteractiveUtils; versioninfo()'`,