Set the group of failed log events to logevent_error

This is to allow clean filtering of log event failures when these are automatically caught by the system.
halleysfifthinc · Jan 5, 2018 · 63ecd06 · 63ecd06
1 parent af7cda9
commit 63ecd06
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/base/logging.jl b/base/logging.jl
@@ -343,7 +343,7 @@ end
  # progressively less information.
  try
  msg = "Exception while generating log record in module $_module at $filepath:$line"
- handle_message(logger, Error, msg, _module, group, id, filepath, line; exception=err)
+ handle_message(logger, Error, msg, _module, :logevent_error, id, filepath, line; exception=err)
  catch err2
  try
  # Give up and write to STDERR, in three independent calls to

diff --git a/test/logging.jl b/test/logging.jl
@@ -84,7 +84,7 @@ end
 
 @testset "Log message exception handling" begin
  # Exceptions in message creation are caught by default
- @test_logs (Error,) catch_exceptions=true @info "foo $(1÷0)"
+ @test_logs (Error,Test.Ignored(),Test.Ignored(),:logevent_error) catch_exceptions=true @info "foo $(1÷0)"
  # Exceptions propagate if explicitly disabled for the logger (by default
  # for the test logger)
  @test_throws DivideError collect_test_logs() do