Skip to content

Commit

Permalink
Revert "Upgrade and use NSIS for compression instead of extra 7z stage (
Browse files Browse the repository at this point in the history
JuliaLang#31879)"

This reverts commit b118e68, reversing
changes made to 1707e13.
  • Loading branch information
musm committed May 3, 2019
1 parent 895f40f commit 289d5b6
Show file tree
Hide file tree
Showing 5 changed files with 43 additions and 6 deletions.
13 changes: 9 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ ifeq ($(DARWIN_FRAMEWORK),1)
endif

distclean:
-rm -fr $(BUILDROOT)/julia-*.tar.gz $(BUILDROOT)/julia*.exe $(BUILDROOT)/julia-$(JULIA_COMMIT)
-rm -fr $(BUILDROOT)/julia-*.tar.gz $(BUILDROOT)/julia*.exe $(BUILDROOT)/julia-*.7z $(BUILDROOT)/julia-$(JULIA_COMMIT)

binary-dist: distclean
ifeq ($(USE_SYSTEM_BLAS),0)
Expand Down Expand Up @@ -463,8 +463,13 @@ ifeq ($(OS), WINNT)

# build nsis package
cd $(BUILDROOT) && $(call spawn,$(JULIAHOME)/dist-extras/nsis/makensis.exe) -NOCD -DVersion=$(JULIA_VERSION) -DArch=$(ARCH) -DCommit=$(JULIA_COMMIT) -DMUI_ICON="$(call cygpath_w,$(JULIAHOME)/contrib/windows/julia.ico)" $(call cygpath_w,$(JULIAHOME)/contrib/windows/build-installer.nsi) | iconv -f latin1
mv "$(BUILDROOT)/julia-installer.exe" "$(BUILDROOT)/$(JULIA_BINARYDIST_FILENAME).exe"

# compress nsis installer and combine with 7zip self-extracting header
cd $(BUILDROOT) && $(JULIAHOME)/dist-extras/7z a -mx9 "julia-install-$(JULIA_COMMIT)-$(ARCH).7z" julia-installer.exe
cd $(BUILDROOT) && cat $(JULIAHOME)/contrib/windows/7zS.sfx $(JULIAHOME)/contrib/windows/7zSFX-config.txt "julia-install-$(JULIA_COMMIT)-$(ARCH).7z" > "$(JULIA_BINARYDIST_FILENAME).exe"
chmod a+x "$(BUILDROOT)/$(JULIA_BINARYDIST_FILENAME).exe"
-rm -f $(BUILDROOT)/julia-install-$(JULIA_COMMIT)-$(ARCH).7z
-rm -f $(BUILDROOT)/julia-installer.exe
else
cd $(BUILDROOT) && $(TAR) zcvf $(JULIA_BINARYDIST_FILENAME).tar.gz julia-$(JULIA_COMMIT)
endif
Expand Down Expand Up @@ -607,10 +612,10 @@ else
endif
cd $(JULIAHOME)/dist-extras && \
$(JLDOWNLOAD) https://downloads.sourceforge.net/sevenzip/7z1900-extra.7z && \
$(JLDOWNLOAD) https://sourceforge.net/projects/nsis/files/NSIS%203/3.04/nsis-3.04-setup.exe && \
$(JLDOWNLOAD) https://storage.googleapis.com/google-code-archive-downloads/v2/code.google.com/unsis/nsis-2.46.5-Unicode-setup.exe && \
chmod a+x 7z.exe && \
chmod a+x 7z.dll && \
$(call spawn,./7z.exe) x -y -onsis nsis-3.04-setup.exe && \
$(call spawn,./7z.exe) x -y -onsis nsis-2.46.5-Unicode-setup.exe && \
chmod a+x ./nsis/makensis.exe

# various statistics about the build that may interest the user
Expand Down
Binary file added contrib/windows/7zS.sfx
Binary file not shown.
4 changes: 4 additions & 0 deletions contrib/windows/7zSFX-config.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
;!@Install@!UTF-8!
Title="The Julia Language"
RunProgram="julia-installer.exe"
;!@InstallEnd@!
27 changes: 27 additions & 0 deletions contrib/windows/7zSFX-manifest.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0">
<compatibility xmlns="urn:schemas-microsoft-com:compatibility.v1">
<application>
<!--Windows Vista -->
<supportedOS Id="{e2011457-1546-43c5-a5fe-008deee3d3f0}"/>
<!--Windows 7 -->
<supportedOS Id="{35138b9a-5d96-4fbd-8e2d-a2440225f93a}"/>
<!--Windows 8 -->
<supportedOS Id="{4a2f28e3-53b9-4441-ba9c-d69d4a4a6e38}"/>
<!--Windows 8.1 and Windows Server 2012 -->
<supportedOS Id="{1f676c76-80e1-4239-95bb-83d0f6d0da78}"/>
</application>
</compatibility>
<dependency>
<dependentAssembly>
<assemblyIdentity type="win32" name="Microsoft.Windows.Common-Controls" version="6.0.0.0" processorArchitecture="*" publicKeyToken="6595b64144ccf1df" language="*"/>
</dependentAssembly>
</dependency>
<trustInfo xmlns="urn:schemas-microsoft-com:asm.v3">
<security>
<requestedPrivileges>
<requestedExecutionLevel level="asInvoker" uiAccess="false"/>
</requestedPrivileges>
</security>
</trustInfo>
</assembly>
5 changes: 3 additions & 2 deletions contrib/windows/build-installer.nsi
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@

Name "The Julia Language"
OutFile "julia-installer.exe"
SetCompressor /SOLID lzma
SetCompressorDictSize 64
SetCompress off
CRCCheck on
SetDataBlockOptimize on
ShowInstDetails show
Expand Down Expand Up @@ -154,3 +153,5 @@ FunctionEnd
Function ShowInstallFolder
ExecShell "open" $INSTDIR
FunctionEnd


0 comments on commit 289d5b6

Please sign in to comment.