-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spacing abstraction layer #64
Comments
I'm agree. In my opinion this is a more accurated way of having spaces that we actually had. :) |
@danifornells , I agree with you as well. In my opinion, this would be a good improvement to apply to the project. Is more consistent and solve some troubles that we found in the past. |
I like the idea. What worries me is about "Collisions like Line Height Systematically" and adding negative margins (that really scare me if other developers have to use it, it can end up in a big mess) |
Great Idea! |
Hey guys! Do you think that we can consider this as done? @danifornells @arnau-pujol @judabelli Or is better to keep the issue opened for future improvements? |
This week I'd read an excellent article about spacings in design systems:
https://medium.com/eightshapes-llc/space-in-design-systems-188bcbae0d62
After some thoughts, I believe it would be nice to have a spacing abstraction layer with those concepts, and remove all spacing related modifiers on objects.
What do you think?
@nucliweb @area73 @arnau-pujol @judabelli @d-asensio
The text was updated successfully, but these errors were encountered: