Skip to content

Commit

Permalink
Merge pull request cedarcode#366 from tcannonfodder/patch-1
Browse files Browse the repository at this point in the history
Fix `advanced_configuration.md` relaying party
  • Loading branch information
bdewater committed Sep 9, 2022
2 parents f24e0e8 + 81d93ae commit 255ca22
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions docs/advanced_configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Intead of the [Global Configuration](../README.md#configuration) you place in `c
# In this case the default would be "admin.example.com", but you can set it to
# the suffix "example.com"
#
# rp_id: "example.com"
# id: "example.com"

# Configure preferred binary-to-text encoding scheme. This should match the encoding scheme
# used in your client-side (user agent) code before sending the credential to the server.
Expand Down Expand Up @@ -171,4 +171,4 @@ end

Adding a configuration for a new instance does not mean you need to get rid of your Global configuration. They can co-exist in your application and be both available for the different usages you might have. `WebAuthn.configuration.relying_party` will always return the global one while `WebAuthn::RelyingParty.new`, executed anywhere in your codebase, will allow you to create a different instance as you see the need. They will not collide and instead operate in isolation without any shared state.

The gem API described in the current [Usage](../README.md#usage) section for the [Global Configuration](../README.md#configuration) approach will still valid but the [Instance Based API](#instance-based-api) also works with the global `relying_party` that is maintain globally at `WebAuthn.configuration.relying_party`.
The gem API described in the current [Usage](../README.md#usage) section for the [Global Configuration](../README.md#configuration) approach will still valid but the [Instance Based API](#instance-based-api) also works with the global `relying_party` that is maintain globally at `WebAuthn.configuration.relying_party`.

0 comments on commit 255ca22

Please sign in to comment.