Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration installation: rephrase procedure #482

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

c0ffeeca7
Copy link

No description provided.

Copy link

coderabbitai bot commented Jun 19, 2024

Warning

Rate limit exceeded

@c0ffeeca7 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 21 minutes and 44 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 44e29a1 and d354a60.

Walkthrough

The updates to basic.md reorganize and streamline the steps for installing and authenticating the HACS integration in Home Assistant. The revisions focus on improving clarity and flow, highlighting prerequisites, and refining the instructional content for better user guidance. The document title and description were also adjusted to better reflect the content's specific focus on HACS integration.

Changes

File Path Change Summary
source/docs/use/configuration/basic.md Reorganized installation and authentication steps for HACS integration. Updated declarations of exported or public entities with refined titles and descriptions for clarity.

Sequence Diagram(s)

No sequence diagrams generated as the changes are primarily content reorganizations and clarifications.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

source/docs/use/configuration/basic.md Show resolved Hide resolved
Comment on lines 16 to 52
1. In Home Assistant, go to <!-- hacs:my info **{{coreui('panel.config')}}** > **{{coreui('ui.panel.config.dashboard.devices.main')}}** -->.
2. Clear your browser cache.
- Before HACS can show up in the list you need to clear your browser cache or perform hard-refresh.
!!! tip
You actually need to do this, don't skip it.

!!! tip
You actually need to do this, don't skip it.
3. In the bottom right corner, select **+ Add integration**.
4. Search for **HACS** and select it.
5. Acknowledge the statements and select **Submit**.
6. Authenticate the integration:
- HACS uses a device OAuth flow for authentication against the GitHub API.
- Copy the device code and select the link [https://github.com/login/device](https://github.com/login/device). **Do not click on submit yet!**

## Add the integration
![image](/assets/images/config_flow/part2.png)

1. Click on the "+ Add integration" button in the bottom right corner.
1. Search for "HACS".
1. Then select (click on) it.
- Sign in to GitHub.
- If you are not signed in to GitHub in your browser you need to signup or sign in now to continue the setup.
- If you are already signed in, you can skip this part.

![image](/assets/images/config_flow/conf3.png)
![image](/assets/images/config_flow/no_account.png)

## Accept usage
- Enter the device code you copied in the previous step and select **Continue**.

![image](/assets/images/config_flow/part1.png)
![image](/assets/images/config_flow/part3.png)

Only the last item (experimental features) are optional, you need to accept everything above that before you can setup HACS.
- Select **Authorize HACS**.

## Device registration
![image](/assets/images/config_flow/part4.png)

HACS uses a device OAuth flow for authentication against the GitHub API.
- Once you see the confirmation screen, you can close the tab and go back to Home Assistant.

---

![image](/assets/images/config_flow/part2.png)

On the first screen you are presented with a device code, copy that to your clipboard and click on the [https://github.com/login/device](https://github.com/login/device) link to continue the setup.

**Do not click on submit yet!**

---

![image](/assets/images/config_flow/no_account.png)

If you are not signed in to GitHub in your browser you need to signup or signin now to continue the setup, if you are already signed in, you can skip this part.

---
![image](/assets/images/config_flow/part5.png)

![image](/assets/images/config_flow/part3.png)
7. To complete the configuration of HACS, select **Submit**.

When that page is loaded up, paste or type in your device code that was presented to you in the previous step.

---

![image](/assets/images/config_flow/part4.png)

Here you click on "Authorize hacs".

---

![image](/assets/images/config_flow/part5.png)

Once you see the confirmation screen, you can close the tab and go back to Home Assistant.

---
![image](/assets/images/config_flow/part2.png)

![image](/assets/images/config_flow/part2.png)
8. Assign HACS to an area and select **Finish**.

Now you can click "Submit" to complete the configuration of HACS.
![image](/assets/images/config_flow/conf5.png)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The installation steps are clear and well-documented. The use of images enhances user understanding. However, consider adding alt text to images for accessibility.

Tools
LanguageTool

[uncategorized] ~18-~18: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...e. - Before HACS can show up in the list you need to clear your browser cache or...


[uncategorized] ~18-~18: Possible missing article found. (AI_HYDRA_LEO_MISSING_A)
Context: ... to clear your browser cache or perform hard-refresh. !!! tip You actual...


[uncategorized] ~22-~22: Consider adding a hyphen. (TOP_LEFT_CORNER)
Context: ...d to do this, don't skip it. 3. In the bottom right corner, select + Add integration. 4...


[style] ~27-~27: Using many exclamation marks might seem excessive (in this case: 5 exclamation marks for a text that’s 1553 characters long) (EN_EXCESSIVE_EXCLAMATION)
Context: ...in/device). Do not click on submit yet! ![image](/assets/images/conf...


[uncategorized] ~32-~32: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...you are not signed in to GitHub in your browser you need to signup or sign in now to co...


[grammar] ~32-~32: The word “signup” is a noun. The verb is spelled with a space. (NOUN_VERB_CONFUSION)
Context: ...n to GitHub in your browser you need to signup or sign in now to continue the setup. ...

source/docs/use/configuration/basic.md Outdated Show resolved Hide resolved
source/docs/use/configuration/basic.md Outdated Show resolved Hide resolved
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

Outside diff range comments (1)
source/docs/use/configuration/basic.md (1)

Line range hint 62-62: The repeated phrasing "you need to" could be varied to improve the readability of the document.

- If you need to change the configuration, you first need to delete the integration from the integrations list, then you need to add it back again.
+ To change the configuration, first delete the integration from the integrations list, then add it back.
Tools
LanguageTool

[uncategorized] ~22-~22: Consider adding a hyphen. (TOP_LEFT_CORNER)
Context: ...d to do this, don't skip it. 3. In the bottom right corner, select + Add integration. 4...


[style] ~27-~27: Using many exclamation marks might seem excessive (in this case: 5 exclamation marks for a text that’s 1556 characters long) (EN_EXCESSIVE_EXCLAMATION)
Context: ...ogin/device). Do not select Submit yet! ![image](/assets/images/conf...

Markdownlint

13-13: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines


59-59: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines

source/docs/use/configuration/basic.md Outdated Show resolved Hide resolved
Comment on lines 16 to 52
1. In Home Assistant, go to <!-- hacs:my info **{{coreui('panel.config')}}** > **{{coreui('ui.panel.config.dashboard.devices.main')}}** -->.
2. Clear your browser cache.
- Before HACS can show up in the list, you need to clear your browser cache or perform a hard-refresh.
!!! tip
You actually need to do this, don't skip it.

!!! tip
You actually need to do this, don't skip it.
3. In the bottom right corner, select **+ Add integration**.
4. Search for **HACS** and select it.
5. Acknowledge the statements and select **Submit**.
6. Authenticate the integration:
- HACS uses a device OAuth flow for authentication against the GitHub API.
- Copy the device code and select the link [https://github.com/login/device](https://github.com/login/device). **Do not select Submit yet!**

## Add the integration
![image](/assets/images/config_flow/part2.png)

1. Click on the "+ Add integration" button in the bottom right corner.
1. Search for "HACS".
1. Then select (click on) it.
- Sign in to GitHub.
- If you are not signed in to GitHub in your browser, you need to sign up or sign in now to continue the setup.
- If you are already signed in, you can skip this part.

![image](/assets/images/config_flow/conf3.png)
![image](/assets/images/config_flow/no_account.png)

## Accept usage
- Enter the device code you copied in the previous step and select **Continue**.

![image](/assets/images/config_flow/part1.png)
![image](/assets/images/config_flow/part3.png)

Only the last item (experimental features) are optional, you need to accept everything above that before you can setup HACS.
- Select **Authorize HACS**.

## Device registration
![image](/assets/images/config_flow/part4.png)

HACS uses a device OAuth flow for authentication against the GitHub API.
- Once you see the confirmation screen, you can close the tab and go back to Home Assistant.

---

![image](/assets/images/config_flow/part2.png)

On the first screen you are presented with a device code, copy that to your clipboard and click on the [https://github.com/login/device](https://github.com/login/device) link to continue the setup.

**Do not click on submit yet!**

---

![image](/assets/images/config_flow/no_account.png)

If you are not signed in to GitHub in your browser you need to signup or signin now to continue the setup, if you are already signed in, you can skip this part.

---
![image](/assets/images/config_flow/part5.png)

![image](/assets/images/config_flow/part3.png)
7. To complete the configuration of HACS, select **Submit**.

When that page is loaded up, paste or type in your device code that was presented to you in the previous step.

---

![image](/assets/images/config_flow/part4.png)

Here you click on "Authorize hacs".

---

![image](/assets/images/config_flow/part5.png)

Once you see the confirmation screen, you can close the tab and go back to Home Assistant.

---
![image](/assets/images/config_flow/part2.png)

![image](/assets/images/config_flow/part2.png)
8. Assign HACS to an area and select **Finish**.

Now you can click "Submit" to complete the configuration of HACS.
![image](/assets/images/config_flow/conf5.png)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The step-by-step installation instructions are clear and detailed. However, consider adding alternative text to images for accessibility and SEO purposes.

- ![image](/assets/images/config_flow/part2.png)
+ ![HACS configuration part 2](/assets/images/config_flow/part2.png)
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
1. In Home Assistant, go to <!-- hacs:my info **{{coreui('panel.config')}}** > **{{coreui('ui.panel.config.dashboard.devices.main')}}** -->.
2. Clear your browser cache.
- Before HACS can show up in the list, you need to clear your browser cache or perform a hard-refresh.
!!! tip
You actually need to do this, don't skip it.
!!! tip
You actually need to do this, don't skip it.
3. In the bottom right corner, select **+ Add integration**.
4. Search for **HACS** and select it.
5. Acknowledge the statements and select **Submit**.
6. Authenticate the integration:
- HACS uses a device OAuth flow for authentication against the GitHub API.
- Copy the device code and select the link [https://github.com/login/device](https://github.com/login/device). **Do not select Submit yet!**
## Add the integration
![image](/assets/images/config_flow/part2.png)
1. Click on the "+ Add integration" button in the bottom right corner.
1. Search for "HACS".
1. Then select (click on) it.
- Sign in to GitHub.
- If you are not signed in to GitHub in your browser, you need to sign up or sign in now to continue the setup.
- If you are already signed in, you can skip this part.
![image](/assets/images/config_flow/conf3.png)
![image](/assets/images/config_flow/no_account.png)
## Accept usage
- Enter the device code you copied in the previous step and select **Continue**.
![image](/assets/images/config_flow/part1.png)
![image](/assets/images/config_flow/part3.png)
Only the last item (experimental features) are optional, you need to accept everything above that before you can setup HACS.
- Select **Authorize HACS**.
## Device registration
![image](/assets/images/config_flow/part4.png)
HACS uses a device OAuth flow for authentication against the GitHub API.
- Once you see the confirmation screen, you can close the tab and go back to Home Assistant.
---
![image](/assets/images/config_flow/part2.png)
On the first screen you are presented with a device code, copy that to your clipboard and click on the [https://github.com/login/device](https://github.com/login/device) link to continue the setup.
**Do not click on submit yet!**
---
![image](/assets/images/config_flow/no_account.png)
If you are not signed in to GitHub in your browser you need to signup or signin now to continue the setup, if you are already signed in, you can skip this part.
---
![image](/assets/images/config_flow/part5.png)
![image](/assets/images/config_flow/part3.png)
7. To complete the configuration of HACS, select **Submit**.
When that page is loaded up, paste or type in your device code that was presented to you in the previous step.
---
![image](/assets/images/config_flow/part4.png)
Here you click on "Authorize hacs".
---
![image](/assets/images/config_flow/part5.png)
Once you see the confirmation screen, you can close the tab and go back to Home Assistant.
---
![image](/assets/images/config_flow/part2.png)
![image](/assets/images/config_flow/part2.png)
8. Assign HACS to an area and select **Finish**.
Now you can click "Submit" to complete the configuration of HACS.
![image](/assets/images/config_flow/conf5.png)
1. In Home Assistant, go to <!-- hacs:my info **{{coreui('panel.config')}}** > **{{coreui('ui.panel.config.dashboard.devices.main')}}** -->.
2. Clear your browser cache.
- Before HACS can show up in the list, you need to clear your browser cache or perform a hard-refresh.
!!! tip
You actually need to do this, don't skip it.
3. In the bottom right corner, select **+ Add integration**.
4. Search for **HACS** and select it.
5. Acknowledge the statements and select **Submit**.
6. Authenticate the integration:
- HACS uses a device OAuth flow for authentication against the GitHub API.
- Copy the device code and select the link [https://github.com/login/device](https://github.com/login/device). **Do not select Submit yet!**
![HACS configuration part 2](/assets/images/config_flow/part2.png)
- Sign in to GitHub.
- If you are not signed in to GitHub in your browser, you need to sign up or sign in now to continue the setup.
- If you are already signed in, you can skip this part.
![image](/assets/images/config_flow/no_account.png)
- Enter the device code you copied in the previous step and select **Continue**.
![image](/assets/images/config_flow/part3.png)
- Select **Authorize HACS**.
![image](/assets/images/config_flow/part4.png)
- Once you see the confirmation screen, you can close the tab and go back to Home Assistant.
![image](/assets/images/config_flow/part5.png)
7. To complete the configuration of HACS, select **Submit**.
![image](/assets/images/config_flow/part2.png)
8. Assign HACS to an area and select **Finish**.
![image](/assets/images/config_flow/conf5.png)
Tools
LanguageTool

[uncategorized] ~22-~22: Consider adding a hyphen. (TOP_LEFT_CORNER)
Context: ...d to do this, don't skip it. 3. In the bottom right corner, select + Add integration. 4...


[style] ~27-~27: Using many exclamation marks might seem excessive (in this case: 5 exclamation marks for a text that’s 1556 characters long) (EN_EXCESSIVE_EXCLAMATION)
Context: ...ogin/device). Do not select Submit yet! ![image](/assets/images/conf...

@c0ffeeca7 c0ffeeca7 changed the title Integration install update Integration installation: rephrase procedure Jun 19, 2024
source/docs/use/configuration/basic.md Outdated Show resolved Hide resolved
source/docs/use/configuration/basic.md Outdated Show resolved Hide resolved
source/docs/use/configuration/basic.md Outdated Show resolved Hide resolved
source/docs/use/configuration/basic.md Outdated Show resolved Hide resolved
@c0ffeeca7 c0ffeeca7 marked this pull request as draft June 20, 2024 05:37
@c0ffeeca7 c0ffeeca7 marked this pull request as ready for review June 20, 2024 05:59
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3


---

![image](/assets/images/config_flow/conf5.png)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra blank lines to adhere to Markdown best practices.

- 

According to Markdownlint rule MD012, multiple consecutive blank lines should be avoided to maintain a clean and professional appearance in Markdown files.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
Tools
Markdownlint

56-56: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines

1. In Home Assistant, go to <!-- hacs:my integrations **{{coreui('panel.config')}}** > **{{coreui('ui.panel.config.dashboard.devices.main')}}** -->.
2. Clear your browser cache.
- Before HACS can show up in the list, you need to clear your browser cache or perform a hard-refresh.
!!! tip
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider reducing the number of exclamation marks for a more professional tone.

- !!! tip
-     You actually need to do this, don't skip it.
+ !!! tip
+     It's important to do this, please do not skip.

Excessive use of exclamation marks can be perceived as unprofessional in documentation. The suggested change maintains the emphasis on not skipping the step while toning down the expression.

Committable suggestion was skipped due to low confidence.

Tools
LanguageTool

[style] ~20-~20: Using many exclamation marks might seem excessive (in this case: 7 exclamation marks for a text that’s 1392 characters long) (EN_EXCESSIVE_EXCLAMATION)
Context: ...er cache or perform a hard-refresh. !!! tip You actually need to do thi...

1. Search for "HACS".
1. Then select (click on) it.
- Sign in to GitHub.
- If you are not signed in to GitHub in your browser, you need to sign up or sign in now to continue the setup.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve the grammatical structure of the sign-in instruction.

- If you are not signed in to GitHub in your browser, you need to sign up or sign in now to continue the setup.
+ If you are not signed in to GitHub in your browser, you must sign up or sign in to continue the setup.

The repeated phrase "you need to" can be simplified to "you must" for better readability and to avoid redundancy.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- If you are not signed in to GitHub in your browser, you need to sign up or sign in now to continue the setup.
- If you are not signed in to GitHub in your browser, you must sign up or sign in to continue the setup.
Tools
LanguageTool

[style] ~33-~33: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing. (REP_NEED_TO_VB)
Context: ...igned in to GitHub in your browser, you need to sign up or sign in now to continue the ...

source/docs/use/configuration/basic.md Outdated Show resolved Hide resolved
source/docs/use/configuration/basic.md Outdated Show resolved Hide resolved
source/docs/use/configuration/basic.md Outdated Show resolved Hide resolved
@ludeeus ludeeus merged commit b63a46e into hacs:next Jun 20, 2024
2 checks passed
@c0ffeeca7 c0ffeeca7 deleted the integration-install-update branch June 20, 2024 07:05