Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing to docs: style tweaks #472

Merged
merged 7 commits into from
Jun 18, 2024

Conversation

c0ffeeca7
Copy link
Contributor

No description provided.

Copy link
Contributor

coderabbitai bot commented Jun 17, 2024

Warning

Rate limit exceeded

@c0ffeeca7 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 40 minutes and 21 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 97250e9 and d806848.

Walkthrough

The updates to documentation.md enhance clarity and specificity in the contribution process, refining instructions and adding new details for better contributor understanding. Significant modifications include rephrasing guidelines, specifying the usage of markdown with mkdocs-material, and detailing in-depth steps for local development and previewing contributions.

Changes

Files/Groups Change Summary
source/docs/contribute/documentation.md Enhanced clarity and specificity in contribution process instructions.
Rephrased sections and refined guidelines for better understanding.
Updated commands and steps for local development and live previews.

Sequence Diagram(s)

sequenceDiagram
    participant Contributor
    participant DocumentationSite
    participant GitHub
    Contributor->>+DocumentationSite: Start devcontainer
    DocumentationSite-->>Contributor: Preview website
    Contributor->>+GitHub: Edit documentation
    GitHub-->>Contributor: Submit changes
    Contributor->>+DocumentationSite: Refresh preview
    DocumentationSite-->>Contributor: Live view changes
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

Outside diff range comments (1)
source/docs/contribute/documentation.md (1)

Line range hint 78-82: The instructions for referencing images are clear, but ensure fenced code blocks are surrounded by blank lines for proper Markdown formatting.

+ ![image](/assets/images/features.png)
Tools
LanguageTool

[grammar] ~59-~59: Did you mean the formatting language “Markdown” (= proper noun)? (MARKDOWN_NNP)
Context: ...nstructions how to create references in markdown.

Referencing another page

Let...

Markdownlint

73-73: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces


56-56: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines


67-67: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines

source/docs/contribute/documentation.md Outdated Show resolved Hide resolved
Comment on lines 59 to 68
Instructions how to create references in markdown.

### Referencing another page

Lets say you need to reference another page that is located under:
Let's say you need to reference another page that is located under:

```text
source/docs/contribute/features.md
```
Then you need to use:
This is a link pointing to the same website. In this case, use a relative link:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure to capitalize "Markdown" when referring to the language for consistency and correctness.

- Instructions how to create references in markdown.
+ Instructions on how to create references in Markdown.
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
Instructions how to create references in markdown.
### Referencing another page
Lets say you need to reference another page that is located under:
Let's say you need to reference another page that is located under:
```text
source/docs/contribute/features.md
```
Then you need to use:
This is a link pointing to the same website. In this case, use a relative link:
Instructions on how to create references in Markdown.
### Referencing another page
Let's say you need to reference another page that is located under:
```text
source/docs/contribute/features.md
```
This is a link pointing to the same website. In this case, use a relative link:
Tools
LanguageTool

[grammar] ~59-~59: Did you mean the formatting language “Markdown” (= proper noun)? (MARKDOWN_NNP)
Context: ...nstructions how to create references in markdown.

Referencing another page

Let...

Markdownlint

67-67: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

source/docs/contribute/documentation.md Outdated Show resolved Hide resolved
source/docs/contribute/documentation.md Outdated Show resolved Hide resolved
c0ffeeca7 and others added 2 commits June 17, 2024 21:13
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

@@ -2,52 +2,52 @@
title: Documentation
description: "Documentation development"
---
The documentation site for HACS is build with [mkdocs-material](https://squidfunk.github.io/mkdocs-material/) and hosted on [Cloudflare Pages](https://pages.cloudflare.com/)
The documentation site for HACS is using [markdown](https://daringfireball.net/projects/markdown/) and built with [mkdocs-material](https://squidfunk.github.io/mkdocs-material/). The site is hosted on [Cloudflare Pages](https://pages.cloudflare.com/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description should reflect the use of Markdown alongside mkdocs-material.

- The documentation site for HACS is using [markdown](https://daringfireball.net/projects/markdown/) and built with [mkdocs-material](https://squidfunk.github.io/mkdocs-material/).
+ The documentation site for HACS uses [Markdown](https://daringfireball.net/projects/markdown/) alongside [mkdocs-material](https://squidfunk.github.io/mkdocs-material/).
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
The documentation site for HACS is using [markdown](https://daringfireball.net/projects/markdown/) and built with [mkdocs-material](https://squidfunk.github.io/mkdocs-material/). The site is hosted on [Cloudflare Pages](https://pages.cloudflare.com/).
The documentation site for HACS uses [Markdown](https://daringfireball.net/projects/markdown/) alongside [mkdocs-material](https://squidfunk.github.io/mkdocs-material/). The site is hosted on [Cloudflare Pages](https://pages.cloudflare.com/).


```yaml
---
title: A Title for the page, this will also be used in the sidebar, ie. Feature
title: A title for the page, this will also be used in the sidebar. For example, Feature.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enhance metadata instructions with examples for better clarity.

- description: "A nice description here"
+ description: "Provide a brief description of the page's content, such as 'Overview of Feature X.'"

Committable suggestion was skipped due to low confidence.

source/docs/contribute/documentation.md Outdated Show resolved Hide resolved
c0ffeeca7 and others added 2 commits June 17, 2024 21:31
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Copy link
Member

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@ludeeus ludeeus merged commit 65ad1a7 into hacs:next Jun 18, 2024
@c0ffeeca7 c0ffeeca7 deleted the contribute-docs-tweaks branch June 18, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants