fix: sanitize pdf url to prevent XSS on inline PDFs #1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Wang <[email protected]>
EastSun5566
force-pushed
the
bugfix/sanitize-url-to-prevent-xss
branch
from
f07f41f
to
11cd200
Compare
Yukaii
approved these changes
Dec 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
Consider the following example, which can trigger an alert popup when inline PDFs are unsupported (like on mobile devices):
The issue arises because PDFObject uses
innerHTMLto insert concatenated fallbackHTML, which could lead to XSS vulnerabilities. For more information, refer to pipwerks/PDFObject#296This can be seen in the code at the following locations:
https://github.com/pipwerks/PDFObject/blob/2c0bbd90d4de64598ff6df9e1af32de2d58a6eb9/pdfobject.js#L275
https://github.com/pipwerks/PDFObject/blob/2c0bbd90d4de64598ff6df9e1af32de2d58a6eb9/pdfobject.js#L323-L329
I think we should sanitize the URL before passing it to
PDFObject.embed. This approach should fix the problem.