Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use encoded note id to update history #1804

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

bbtfr
Copy link
Contributor

@bbtfr bbtfr commented Apr 10, 2023

fixes: #1570

In the current version, if I call PUT /api/notes/:noteId, my note will be updated properly, but in history page, I will get 2 notes with the same name, one linked to /uuid (which can not be opened, 404) and the other linked to /encoded_id (this is what I want)

I did some digging, and noticed that both note.id and noteId here in updateNote are uuid, not encoded note id, we have to call Note.encodeNoteId to make it work

@bbtfr
Copy link
Contributor Author

bbtfr commented Apr 13, 2023

Hi, @jackycute can you please take a look when you get a chance?

@jackycute
Copy link
Member

Hi @bbtfr,
This looks good to me.

@jackycute
Copy link
Member

@bbtfr Thanks for your PR!

@jackycute jackycute merged commit 298db32 into hackmdio:develop Jun 5, 2023
@stanley2058 stanley2058 mentioned this pull request Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants