Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: may referernce out of bound index in clearDuplicatedHistory #1706

Merged

Conversation

a60814billy
Copy link
Member

should use j to reference newnotehistory array to avoid incorrect array index reference.

@Yukaii Yukaii temporarily deployed to codimd-pr-1706 July 31, 2021 12:19 Inactive
@a60814billy a60814billy force-pushed the fix/incorrect-array-index-reference-in-clearDuplicatedHistory branch from ed231b6 to b2e2743 Compare July 31, 2021 12:20
@Yukaii Yukaii temporarily deployed to codimd-pr-1706 July 31, 2021 12:20 Inactive
@jackycute jackycute added this to the Next milestone Oct 10, 2021
@Yukaii Yukaii merged commit 5db11d2 into develop Oct 15, 2021
@Yukaii Yukaii deleted the fix/incorrect-array-index-reference-in-clearDuplicatedHistory branch October 15, 2021 09:55
@a60814billy a60814billy mentioned this pull request Jan 18, 2022
edgarogh pushed a commit to WartaPoirier-corp/codimd that referenced this pull request Jun 7, 2022
Signed-off-by: Renovate Bot <[email protected]>

Co-authored-by: Renovate Bot <[email protected]>
@Yukaii Yukaii modified the milestones: Next, 2.5.0 Dec 26, 2023
@stanley2058 stanley2058 mentioned this pull request Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants