Support anonymous updates via API if allowAnonymousEdits is true #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Giuseppe Lo Presti <[email protected]>
Yukaii
requested changes
Mar 18, 2021
Co-authored-by: Yukai Huang <[email protected]> Signed-off-by: Giuseppe Lo Presti <[email protected]>
Yukaii
approved these changes
Mar 22, 2021
@glpatcern Thanks for the contribution 🎉 . Could you give us more details about the integration? |
Sure! I'll tell you more over gitter, the overall approach was simple with no radical changes (e.g. no DB schema changes) but with some UI retouches, following a bit the model of etherpad. @mic4ael has been a great contributor ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR introduces the ability to use the newly provided update API anonymously, when the system is configured to work in anonymous mode (i.e.
allowAnonymousEditsis true).Also logging in case of error was extended with the stack trace to match similar code in the project.
The patch was successfully tested and is currently used in a pilot deployment, where CodiMD is being integrated with an external storage and controlled via API, therefore user authentication/authorization is delegated to the external storage. I can provide further information and hopefully more PRs that have helped in our integration.