fix: avoid eval string when putting back parsed string of mermaid #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
where has stored XSS issue Signed-off-by: Max Wu <[email protected]>
jackycute
force-pushed
the
bugfix/fix-mermaid-render-xss
branch
from
79dc6a9
to
8d9a9ab
Compare
Signed-off-by: Max Wu <[email protected]>
jackycute
force-pushed
the
bugfix/fix-mermaid-render-xss
branch
from
e6b8af2
to
064dfb7
Compare
Signed-off-by: Max Wu <[email protected]>
Yukaii
approved these changes
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1630
Avoid using element.html for putting back parsed string of mermaid where can trigger stored XSS attacks.