Fix matchInContainer false positives #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function should match only the beginnings of lines. For example, see this testcase: ``` :::spoiler here is a ::: ::: ::: ``` The last line should be completed. Without this patch, the third line is completed and the last is not. Signed-off-by: Tamotsu Takahashi <[email protected]>
Yukaii
reviewed
May 11, 2021
simplify the regex suggested by yukaii in #1605 Co-authored-by: Yukai Huang <[email protected]>
simplify the regex suggested by yukaii in #1605 Co-authored-by: Yukai Huang <[email protected]> Signed-off-by: Tamotsu Takahashi <[email protected]>
jakubgs
pushed a commit
to status-im/codimd
that referenced
this pull request
Aug 23, 2021
simplify the regex suggested by yukaii in hackmdio#1605 Co-authored-by: Yukai Huang <[email protected]> Signed-off-by: Tamotsu Takahashi <[email protected]>
edgarogh
pushed a commit
to WartaPoirier-corp/codimd
that referenced
this pull request
Sep 21, 2021
Signed-off-by: Renovate Bot <[email protected]> Co-authored-by: Renovate Bot <[email protected]>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function should match only the beginnings of lines.
For example, see this testcase:
The last line should be completed, and the third should not.
Without this patch, the third line is completed and the last is not.
FYI, this patch is not perfect, either.
If the third line is ":::bogus", the parser won't treat it as the closer. But matchInContainer will.
So the right regexp would be /(^|\n):::\s*(success|info|warning|danger|spoiler)($|\s)/ but who cares