Move HTML-related code from JS to EJS to enable more i18n #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tamo This PR also needs to be rebased 👍 |
added 3 commits
September 11, 2020 12:50
#1581 (comment) Signed-off-by: Tamotsu Takahashi <[email protected]>
Move HTML from JS to EJS. #1581 (comment) #1581 (comment) Signed-off-by: Tamotsu Takahashi <[email protected]>
Move HTML from JS to EJS I don't know how to register i18n helper to handlebars, so "export to raw HTML" has not been touched. You can do the same for html.hbs if you want. Signed-off-by: Tamotsu Takahashi <[email protected]>
jackycute
approved these changes
Jul 9, 2021
edgarogh
pushed a commit
to WartaPoirier-corp/codimd
that referenced
this pull request
Sep 21, 2021
Signed-off-by: Renovate Bot <[email protected]> Co-authored-by: Renovate Bot <[email protected]>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't manipulate HTML in JS but just show/hide existing elements.
This way, we can translate more.
See #1581