Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert "include" directives to functions #1580

Merged
merged 2 commits into from
Jul 9, 2021
Merged

Convert "include" directives to functions #1580

merged 2 commits into from
Jul 9, 2021

Conversation

tamo
Copy link
Contributor

@tamo tamo commented Aug 22, 2020

Close #1578

@Yukaii Yukaii temporarily deployed to codimd-master-qxxuus5uyvetzx2l August 28, 2020 10:03 Inactive
@Yukaii Yukaii temporarily deployed to codimd-master-qxxuus5uyvetzx2l August 29, 2020 00:06 Inactive
@Yukaii Yukaii temporarily deployed to codimd-master-qxxuus5uyvetzx2l September 4, 2020 01:33 Inactive
@Yukaii Yukaii changed the base branch from master to develop September 10, 2020 07:45
@Yukaii
Copy link
Member

Yukaii commented Sep 10, 2020

@tamo This PR also needs to be rebased :)

@Yukaii Yukaii added this to the Next milestone Sep 10, 2020
@Yukaii Yukaii temporarily deployed to codimd-master-qxxuus5uyvetzx2l September 10, 2020 08:51 Inactive
@Yukaii
Copy link
Member

Yukaii commented Sep 10, 2020

We use standardjs linter in the CodiMD project. To keep coding style consistent, let's remove the semicolons! @tamo

@Yukaii Yukaii temporarily deployed to codimd-master-qxxuus5uyvetzx2l September 11, 2020 04:10 Inactive
#1580 (comment)

Signed-off-by: Tamotsu Takahashi <[email protected]>
@Yukaii Yukaii temporarily deployed to codimd-master-qxxuus5uyvetzx2l September 11, 2020 04:34 Inactive
@jackycute jackycute modified the milestone: Next May 12, 2021
Copy link
Member

@jackycute jackycute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tamo

@a60814billy a60814billy merged commit 620197f into hackmdio:develop Jul 9, 2021
jakubgs pushed a commit to status-im/codimd that referenced this pull request Aug 23, 2021
@a60814billy a60814billy mentioned this pull request Jan 18, 2022
@Yukaii Yukaii modified the milestones: Next, 2.5.0 Dec 26, 2023
@stanley2058 stanley2058 mentioned this pull request Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

args for include in EJS should be surrounded
4 participants