Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and delete note api #1559

Merged
merged 11 commits into from
Aug 13, 2020
Merged

Update and delete note api #1559

merged 11 commits into from
Aug 13, 2020

Conversation

JamesCamel
Copy link
Contributor

  1. CodiMD note content update API
  • PUT /api/notes/${noteId}
  • body: (JSON) content: string
  1. CodiMD note delete API
  • DELETE /api/notes/${noteId}
  • Check owenerId

@Yukaii Yukaii temporarily deployed to codimd-feature-update-d-soxs0k July 21, 2020 01:21 Inactive
@JamesCamel JamesCamel marked this pull request as draft July 21, 2020 01:21
@JamesCamel JamesCamel force-pushed the feature/update-delete-note-api branch from 4590d84 to 5f51add Compare July 21, 2020 01:22
@Yukaii Yukaii temporarily deployed to codimd-feature-update-d-soxs0k July 21, 2020 01:23 Inactive
@JamesCamel JamesCamel requested a review from Yukaii July 21, 2020 01:43
@Yukaii Yukaii added this to the Next milestone Jul 21, 2020
Yukaii
Yukaii reviewed Jul 21, 2020
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
@Yukaii Yukaii temporarily deployed to codimd-feature-update-d-soxs0k July 22, 2020 14:42 Inactive
@Yukaii Yukaii temporarily deployed to codimd-feature-update-d-soxs0k July 27, 2020 10:00 Inactive
@JamesCamel JamesCamel force-pushed the feature/update-delete-note-api branch from 53f45aa to 53526c1 Compare July 27, 2020 10:01
@Yukaii Yukaii temporarily deployed to codimd-feature-update-d-soxs0k July 27, 2020 10:01 Inactive
@JamesCamel JamesCamel requested a review from Yukaii July 27, 2020 10:06
Yukaii
Yukaii reviewed Jul 28, 2020
View reviewed changes
lib/note/index.js Outdated Show resolved Hide resolved
Yukaii
Yukaii reviewed Jul 28, 2020
View reviewed changes
lib/routes.js Outdated Show resolved Hide resolved
Yukaii
Yukaii reviewed Jul 29, 2020
View reviewed changes
lib/note/index.js Outdated Show resolved Hide resolved
@Yukaii Yukaii temporarily deployed to codimd-feature-update-d-soxs0k July 30, 2020 10:14 Inactive
@JamesCamel JamesCamel force-pushed the feature/update-delete-note-api branch from d7e00db to 04fe74d Compare July 30, 2020 10:15
@Yukaii Yukaii temporarily deployed to codimd-feature-update-d-soxs0k July 30, 2020 10:15 Inactive
@Yukaii Yukaii temporarily deployed to codimd-feature-update-d-soxs0k July 30, 2020 10:56 Inactive
@JamesCamel JamesCamel force-pushed the feature/update-delete-note-api branch from 32aeb85 to 091c77b Compare July 30, 2020 10:57
@Yukaii Yukaii temporarily deployed to codimd-feature-update-d-soxs0k July 30, 2020 10:57 Inactive
@JamesCamel JamesCamel requested a review from Yukaii August 3, 2020 08:01
@Yukaii Yukaii marked this pull request as ready for review August 4, 2020 07:23
@Yukaii Yukaii temporarily deployed to codimd-feature-update-d-soxs0k August 4, 2020 08:48 Inactive
@JamesCamel JamesCamel force-pushed the feature/update-delete-note-api branch from 9edf63f to e7a4996 Compare August 4, 2020 08:48
@Yukaii Yukaii temporarily deployed to codimd-feature-update-d-soxs0k August 4, 2020 08:49 Inactive
@JamesCamel
Fix linter
4792908 
Signed-off-by: James Tsai <[email protected]>
@Yukaii Yukaii temporarily deployed to codimd-feature-update-d-soxs0k August 4, 2020 09:11 Inactive
@JamesCamel JamesCamel force-pushed the feature/update-delete-note-api branch from deea43b to 4792908 Compare August 4, 2020 09:11
@Yukaii Yukaii temporarily deployed to codimd-feature-update-d-soxs0k August 4, 2020 09:11 Inactive
@JamesCamel JamesCamel requested a review from Yukaii August 4, 2020 09:22
@Yukaii
Fix updateHistory parameter
ab0ac83 
Signed-off-by: Yukai Huang <[email protected]>
@Yukaii Yukaii temporarily deployed to codimd-feature-update-d-soxs0k August 12, 2020 10:11 Inactive
@Yukaii Yukaii added the api label Aug 13, 2020
@Yukaii
Copy link
Member

Yukaii commented Aug 13, 2020

Thank you @JamesCamel

@Yukaii Yukaii merged commit 24de5a5 into develop Aug 13, 2020
@Yukaii Yukaii deleted the feature/update-delete-note-api branch August 13, 2020 07:55
@MHajoha MHajoha mentioned this pull request Oct 23, 2020
Open
@Yukaii Yukaii modified the milestones: Next, 2.3.0 Dec 25, 2020
edgarogh pushed a commit to WartaPoirier-corp/codimd that referenced this pull request Sep 21, 2021
@davidmehren
Merge pull request hackmdio#1559 from hedgedoc/ignore-local-fonts
e081f77 
Ignore local installed fonts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yukaii Yukaii Yukaii approved these changes

Assignees
No one assigned
Labels
api
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JamesCamel @Yukaii