Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webpack urlpath font loading error #1551

Merged
merged 3 commits into from
Jul 10, 2020
Merged

Fix webpack urlpath font loading error #1551

merged 3 commits into from
Jul 10, 2020

Conversation

Yukaii
Copy link
Member

@Yukaii Yukaii commented Jul 6, 2020

fixes #616
fixes #1538
fixes #1165

@Yukaii Yukaii temporarily deployed to codimd-bugfix-urlpath-jm5hkqlp July 6, 2020 07:37 Inactive
@Yukaii Yukaii temporarily deployed to codimd-bugfix-urlpath-jm5hkqlp July 10, 2020 03:18 Inactive
Use copy webpack plugin instead. In the old fasion

Signed-off-by: Yukai Huang <[email protected]>
@Yukaii Yukaii temporarily deployed to codimd-bugfix-urlpath-jm5hkqlp July 10, 2020 08:09 Inactive
@Yukaii Yukaii temporarily deployed to codimd-bugfix-urlpath-jm5hkqlp July 10, 2020 08:17 Inactive
@Yukaii Yukaii added this to the Next milestone Jul 10, 2020
@Yukaii Yukaii added the bug Something isn't working label Jul 10, 2020
@Yukaii Yukaii changed the title WIP: Fix webpack urlpath Fix webpack urlpath Jul 10, 2020
@Yukaii Yukaii changed the title Fix webpack urlpath Fix webpack urlpath font loading error Jul 10, 2020
Copy link
Member

@jackycute jackycute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Yukaii

@jackycute jackycute merged commit 6804711 into develop Jul 10, 2020
@jackycute jackycute deleted the bugfix/urlpath branch July 10, 2020 09:37
@Yukaii Yukaii modified the milestones: Next, 2.2.0 Jul 20, 2020
edgarogh pushed a commit to WartaPoirier-corp/codimd that referenced this pull request Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants