fix: handle error when check is image valid

Signed-off-by: Charlie Hsieh <[email protected]>
hackmdio · Jan 13, 2023 · 1ab2a36 · 1ab2a36
1 parent 8efc2d0
commit 1ab2a36
Showing 1 changed file with 11 additions and 6 deletions.
diff --git a/lib/imageRouter/index.js b/lib/imageRouter/index.js
@@ -16,13 +16,18 @@ const response = require('../response')
 const imageRouter = module.exports = Router()
 
 function checkImageValid (filepath) {
- const buffer = readChunk.sync(filepath, 0, 12)
- /** @type {{ ext: string, mime: string } | null} */
- const mimetypeFromBuf = imageType(buffer)
- const mimeTypeFromExt = mime.lookup(path.extname(filepath))
+ try {
+ const buffer = readChunk.sync(filepath, 0, 12)
+ /** @type {{ ext: string, mime: string } | null} */
+ const mimetypeFromBuf = imageType(buffer)
+ const mimeTypeFromExt = mime.lookup(path.extname(filepath))
 
- return mimetypeFromBuf && config.allowedUploadMimeTypes.includes(mimetypeFromBuf.mime) &&
- mimeTypeFromExt && config.allowedUploadMimeTypes.includes(mimeTypeFromExt)
+ return mimetypeFromBuf && config.allowedUploadMimeTypes.includes(mimetypeFromBuf.mime) &&
+ mimeTypeFromExt && config.allowedUploadMimeTypes.includes(mimeTypeFromExt)
+ } catch (err) {
+ logger.error(err)
+ return false
+ }
 }
 
 // upload image