-
-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add git-hub handle for Tien Yuan in heart #7001
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
_projects/heart.md
Outdated
@@ -52,6 +52,7 @@ leadership: | |||
github: https://github.com/abregorivas | |||
picture: https://avatars2.githubusercontent.com/u/7821047?s=400&u=9128a4d0a4d1ff33bdebae02bcdaac7ff7e7432f&v=4 | |||
- name: Tien Yuan | |||
github-handle: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is correct
ETA: 06/13/24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @troyfreed,
- Your branch title should be a brief description of the issue that will make sense at a glance to someone unfamiliar with the issue. Refer to the guide https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md#27b-working-on-an-issue-2-create-a-new-branch-where-you-will-work-on-your-issue
- Just a small notice, check the spelling of “git-hub handle”. I think “github-handle” would be more appropriate
- Issue number was listed
- The PR request clearly states what and why was updated
- The code changes were applied correctly
Thanks! Once you’ve made these updates, I’ll be ready to approve it.
I just fixed the issue, let me know if there is anything else I need to
change.
…On Thu, Jun 13, 2024 at 8:28 PM Delgira Dordzhieva ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Hey @troyfreed <https://github.com/troyfreed>,
- Your branch title should be a brief description of the issue that
will make sense at a glance to someone unfamiliar with the issue. Refer to
the guide
https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md#27b-working-on-an-issue-2-create-a-new-branch-where-you-will-work-on-your-issue
- Just a small notice, check the spelling of “git-hub handle”. I think
“github-handle” would be more appropriate
- Issue number was listed
- The PR request clearly states what and why was updated
- The code changes were applied correctly
Thanks! Once you’ve made these updates, I’ll be ready to approve it.
—
Reply to this email directly, view it on GitHub
<#7001 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXC3V32Z4IIC2RYZZEOSU5DZHJBMZAVCNFSM6AAAAABJJASLLCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMJXGI2TSNJYGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
You should create a branch like this: git checkout -b update-give-link-2093: |
Do I still have to do this if I am making changes through the Visual
Studios Git graphical user interface, not the terminal?
On Tue, Jun 18, 2024 at 9:54 AM Delgira Dordzhieva ***@***.***>
wrote:
… I just fixed the issue, let me know if there is anything else I need to
change.
… <#m_1751075508427760458_>
On Thu, Jun 13, 2024 at 8:28 PM Delgira Dordzhieva *@*.*> wrote: @.**
requested changes on this pull request. Hey @troyfreed
<https://github.com/troyfreed> https://github.com/troyfreed, - Your
branch title should be a brief description of the issue that will make
sense at a glance to someone unfamiliar with the issue. Refer to the guide
https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md#27b-working-on-an-issue-2-create-a-new-branch-where-you-will-work-on-your-issue
- Just a small notice, check the spelling of “git-hub handle”. I think
“github-handle” would be more appropriate - Issue number was listed - The
PR request clearly states what and why was updated - The code changes were
applied correctly Thanks! Once you’ve made these updates, I’ll be ready to
approve it. — Reply to this email directly, view it on GitHub <#7001
(review)
<#7001 (review)>>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXC3V32Z4IIC2RYZZEOSU5DZHJBMZAVCNFSM6AAAAABJJASLLCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMJXGI2TSNJYGY
. You are receiving this because you were mentioned.Message ID: *@*.***>
You should create a branch like this: git checkout -b
update-give-link-2093:
Screenshot.2024-06-18.at.10.49.49.png (view on web)
<https://github.com/hackforla/website/assets/107867458/9b2225ff-5711-45ee-a583-8e5b5f1f7ef5>
https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md#27b-working-on-an-issue-2-create-a-new-branch-where-you-will-work-on-your-issue
—
Reply to this email directly, view it on GitHub
<#7001 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXC3V34P2EN5ZC5VJBQIJFLZIBC2VAVCNFSM6AAAAABJJASLLCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZWGMYDQOJUHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi @troyfreed, It looks like you're using the main branch (gh-pages) for this pull request, which isn't permitted. Please create a feature branch for your changes and submit the pull request from that branch. I suggest closing this PR and starting fresh with a feature branch. Please refer to the Working an issue section in the contributing guide. It applies whether you are using the terminal or GUI in VS Code. If you have any questions or need assistance, please attend one of the dev meetings or reach out to the #hfla-site channel on Slack. Thanks! |
It looks like someone in the merge team has started on the last part of the
issue and has already edited the work I was supposed to do plus other stuff
in the project. Should I still make a new pull request if my changes have
already been confirmed through the other issue?
…On Thu, Jun 20, 2024 at 12:59 PM J Pham ***@***.***> wrote:
Hi @troyfreed <https://github.com/troyfreed>,
It looks like you're using the main branch (gh-pages) for this pull
request, which isn't permitted. Please create a feature branch for your
changes and submit the pull request from that branch. I suggest closing
this PR and starting fresh with a feature branch.
Please refer to the Working an issue
<https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md#27-working-on-an-issue>
section in the contributing guide. It applies whether you are using the
terminal or GUI in VS Code.
If you have any questions or need assistance, please attend one of the dev
meetings or reach out to the #hfla-site channel on Slack. Thanks!
—
Reply to this email directly, view it on GitHub
<#7001 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXC3V36L6XGVRKFAMSUXRPTZIMYBPAVCNFSM6AAAAABJJASLLCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBRGQ2DGMZYGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@troyfreed Issue #6941 has not been worked on and merged yet. It is still open. As requested in earlier comments, please close this PR, and then follow to instructions in CONTIBUTING.md-2.7.b to start working on the issue. |
Fixes #6941
What changes did you make?
-added a variable "github-handle" to Tien Yuan's name in project heart
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
There are no changes to the website because "github-handle" has no value yet.