Add file player to fix khrj's workflow #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
khrj
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new route,
/deprecated-file-player, which is a barebones player-only page that autoruns. It supports two URL parameters,fileto load a file from URL, andwatchto rerun when the file changes.@khrj I recognize that this is more barebones than the original PR, but I wonder if this is enough to fix your workflow? If not, please let me know what you need.
Calling it deprecated because I don't want to encourage using this for anything except to un-break existing projects relying on the parameters you added in #644. I'm planning on likely removing this page if we publish an NPM package and make sure everything relying on this migrates over.
When merged this will fix #908.