Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add lint-sprig script and missing games. #971

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

shanecelis
Copy link
Collaborator

Re-adding games and lint-sprig script.

@vercel
Copy link

vercel bot commented Mar 15, 2023

@shanecelis is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

@grymmy
Copy link
Contributor

grymmy commented Mar 15, 2023

@shanecelis I will review this today and also ensure your vercel privs get figured out.

@sampoder
Copy link
Member

@grymmy can you fill me in, what are the Vercel issues?

@vercel
Copy link

vercel bot commented Mar 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
sprig ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 15, 2023 at 1:29PM (UTC)

@vercel vercel bot temporarily deployed to Preview – sprig March 15, 2023 13:29 Inactive
@grymmy
Copy link
Contributor

grymmy commented Mar 15, 2023

@grymmy can you fill me in, what are the Vercel issues?

Heck you might have a better idea than I, but I figured the warnings above
Screenshot 2023-03-15 at 10 12 46 AM

could be resolved and vercel could auto-deploy if Shane had proper perms...? To be honest, I'd like to really dig into how we stage deployments (see #970)

@sampoder
Copy link
Member

@shanecelis can you DM your email? I'll add you to our Vercel account. Assuming that's linked to your GitHub account, that'll give you the correct perms.

@grymmy
Copy link
Contributor

grymmy commented Mar 16, 2023

@shanecelis can you DM your email? I'll add you to our Vercel account. Assuming that's linked to your GitHub account, that'll give you the correct perms.

Thanks for following up on this @sampoder.

Copy link
Contributor

@grymmy grymmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grymmy grymmy merged commit 7350072 into hackclub:main Mar 16, 2023
@LucasHT22 LucasHT22 added the enhancement New feature or request label Mar 16, 2023
@shanecelis
Copy link
Collaborator Author

DM’d you, @sampoder.

@shanecelis shanecelis mentioned this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants