Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pong-multiplayer game #696

Merged
merged 4 commits into from
Jan 1, 2023
Merged

Add pong-multiplayer game #696

merged 4 commits into from
Jan 1, 2023

Conversation

devramsean0
Copy link
Member

What is your game about?
It is a version of pong that allows for 2 player multiplayer

How to play your game?

Player Up Down Colour
1 W S Black
2 I K Red

Code

Check off the items that are true.

  • [ x] The game was made using the Sprig editor.
  • [ x] The game is placed in the in the /games directory.
  • [ x] The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
  • [ x] The game runs without errors.
  • [ x] The name of the file/game contains only alphanumeric characters, -s, or _s.
  • [ x] The game name is not the same as the others from gallery

Image (If an image is used)

Not used

  • The image is in the /games/img directory.
  • The name of the image matches the name of your file. Example: sokoban_plus.js -> sokoban_plus.png.

@vercel
Copy link

vercel bot commented Jan 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
sprig ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 1, 2023 at 6:36PM (UTC)

@vercel vercel bot temporarily deployed to Preview – sprig January 1, 2023 14:47 Inactive
@LucasHT22 LucasHT22 added the submission Game submission label Jan 1, 2023
@vercel vercel bot temporarily deployed to Preview – sprig January 1, 2023 16:11 Inactive
@LucasHT22
Copy link
Member

Thanks for PR! 2 bugs, after the end the ball keeps moving and when it hits outside the player's space, it also scores a point

@devramsean0
Copy link
Member Author

I fixed the ball moving after end of game bug, but the other one is gonna require a rewrite of the scoring system, groan

@vercel vercel bot temporarily deployed to Preview – sprig January 1, 2023 18:34 Inactive
@devramsean0
Copy link
Member Author

I think I have fixed both now

Copy link
Member

@LucasHT22 LucasHT22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes! Looks good to me. Congrats:)
If you're a teen, you can get your sprig here! https://sprig-order.hackclub.dev/

@LucasHT22 LucasHT22 merged commit fd7c5ee into hackclub:main Jan 1, 2023
LucasHT22 added a commit that referenced this pull request Jan 1, 2023
LucasHT22 added a commit that referenced this pull request Jan 2, 2023
LucasHT22 added a commit that referenced this pull request Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
submission Game submission
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants