Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple rendering #588

Merged
merged 8 commits into from
Dec 3, 2022
Merged

Simple rendering #588

merged 8 commits into from
Dec 3, 2022

Conversation

leomcelroy
Copy link
Collaborator

Reverting back to canvas rendering. Addresses some minor rendering issues such as limit of 4 sprites per tile. Also makes sprig engine more easily usable as a library.

@vercel
Copy link

vercel bot commented Nov 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
sprig ✅ Ready (Inspect) Visit Preview Dec 3, 2022 at 1:16AM (UTC)

@leomcelroy
Copy link
Collaborator Author

I would love help checking every game before we merge this in. @Omay238 @LucasHT22 @Neesh774 @samdev-7

@LucasHT22
Copy link
Member

I'll check now

@LucasHT22
Copy link
Member

LucasHT22 commented Nov 29, 2022

all games are playable, in yarn test only Snake_4_2 returns error in properties x and y, I've tried everything but I couldn't solve it

@Omay238
Copy link
Contributor

Omay238 commented Nov 29, 2022

@LucasHT22 Can you put a screenshot in the github thread? I have been unable to access Slack recently. I can try to debug it.

@LucasHT22
Copy link
Member

ok!
image

@Omay238
Copy link
Contributor

Omay238 commented Nov 29, 2022

I think I fixed it. I changed every time it looks for something.x to check that it exists. I also changed == -> === and != -> !== to just be correct JS syntax.

@LucasHT22
Copy link
Member

LucasHT22 commented Nov 29, 2022

Very good Omay! Congrats IMG_20221129_193733~2.jpg

@leomcelroy
Copy link
Collaborator Author

It's because there are random inputs so the test is not exhaustive or repeatable. But the test also looks at the map not the render. So really we have to manually check the games.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants