Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editor bug caused by repeatedly replacing CodeMirror instance #1837

Merged
merged 17 commits into from
Jun 25, 2024

Conversation

recursiveforte
Copy link
Member

Previous fix didn't work.

GalaxyGamingBoy and others added 15 commits June 14, 2024 11:19
revert formating

revert formating
…ta/[id], remove chatty console logs, throw an error if persistence state is not passed, make the signaling server env variable, extract waitInitialUpdate to separate function, make it so if room connection couldn't be established, refresh, add comment block for start-saving endpoint, send 500 if save to db throws error, fix bug where saving strat boolean doesn't change, fix env variable usage
Copy link

vercel bot commented Jun 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sprig ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 2:10pm

Copy link
Collaborator

@Cosmin-Mare Cosmin-Mare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@recursiveforte recursiveforte merged commit 9809c56 into main Jun 25, 2024
2 checks passed
@recursiveforte recursiveforte deleted the fix-effect branch June 25, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants