Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad Apple port on Sprig #1405

Merged
merged 5 commits into from
Jan 28, 2024
Merged

Bad Apple port on Sprig #1405

merged 5 commits into from
Jan 28, 2024

Conversation

Sychamis
Copy link
Contributor

@Sychamis Sychamis commented Jan 21, 2024

Your checklist for this pull request

Author name

Author:

Sychamis

About your game

What is your game about?

Watching the Sprig port of the Bad Apple video (https://www.youtube.com/watch?v=FtutLA63Cp8)

Context: people try to play the video on everything they can so I thought It'd be cool to add a Sprig port to the list (https://www.youtube.com/playlist?list=PLajlU5EKJVdonUGTEc7B-0YqElDlz9Sf9)

How do you play your game?

Select the playback frame-rate with J (15 fps) or L (30 fps, but it can lag and desync the music), and enjoy.

Code

Check off the items that are true.

  • The game was made using the Sprig editor.
  • The game is placed in the in the /games directory.
  • The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
  • The game runs without errors.
  • The name of the file/game contains only alphanumeric characters, -s, or _s.
  • The game name is not the same as the others from gallery

Image (If an image is used)

Thanks for your PR!

Video data converted with python, music covered by hand using a python tool I made, played by custom scripts in the javascript file.
Copy link

vercel bot commented Jan 21, 2024

@Sychamis is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

@LucasHT22 LucasHT22 self-assigned this Jan 22, 2024
@LucasHT22 LucasHT22 added the submission Game submission label Jan 22, 2024
Copy link
Member

@LucasHT22 LucasHT22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Out of curiosity, did you use any game for inspiration?

@Sychamis
Copy link
Contributor Author

The game ROOM by davnotdev gave me the idea to use a tilemap as a framebuffer and the setInterval() function to refresh graphics and prevent music from slowing down.

@LucasHT22
Copy link
Member

The game ROOM by davnotdev gave me the idea to use a tilemap as a framebuffer and the setInterval() function to refresh graphics and prevent music from slowing down.

hmm did you use any code from another person?

@Sychamis
Copy link
Contributor Author

I planned to use davnotdev's code (and credit him) if my own code wouldn't work: I first tried to make the framebuffer myself and it happened to work properly with some tweaks. So in the end I didn't use code from anyone except myself (because I made the python music scripts and JS player for a previous project.)
However, as mentionned in my code, I got video data from 52525rr and she made the encoding and ffmpeg video scanning so I find it fair to credit her even if it's not code.

Copy link
Member

@LucasHT22 LucasHT22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right:) Where did you hear about Sprig?

@Sychamis
Copy link
Contributor Author

I discovered sprig when people in a discord server were talking about hackclub, I took a look at what the organization was then checked its repos and I clicked on the first one out of curiosity 👀

@LucasHT22
Copy link
Member

hmmmm out of curiosity, are you on hackclub slack?

@Sychamis
Copy link
Contributor Author

No I'm not on it.

@LucasHT22
Copy link
Member

No I'm not on it.

Right:) out of curiosity why bad apple?

@Sychamis
Copy link
Contributor Author

Because on the list of "port it on everything" projects it's by far the most popular and easy one, the other ones being STNICCC 2000 (rendering a polygon stream animation) and of course DOOM.

@LucasHT22
Copy link
Member

Right, could you give me 24 hours to analize it better? We had many people doing bad apple for Sprig so I'll make sure it's not plagiarism

Copy link

Plagiarism Report

Game overlap report:

None detected

@Sychamis
Copy link
Contributor Author

Sure !

Copy link
Member

@LucasHT22 LucasHT22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit to me! Nice method:)
Congrats:)
If you're a teen, you can get your sprig here! https://sprig-order.hackclub.dev/

Hack Clubbers would love to see this! Just post a link and 1-2 sentences talking about your game to our #ship channel:)

Copy link

vercel bot commented Jan 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sprig ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2024 1:39am

@vercel vercel bot temporarily deployed to Preview – sprig January 27, 2024 02:10 Inactive
@LucasHT22
Copy link
Member

I'll merge later because i need to update your metadata but my github isn't loading the file
image

Copy link

Plagiarism Report

Game overlap report:

None detected

@Sychamis
Copy link
Contributor Author

Thanks! I'll try to join the sprig slack and apply for the console but I'm a bit worried about having to give my personal infomation.

@LucasHT22
Copy link
Member

Thanks! I'll try to join the sprig slack and apply for the console but I'm a bit worried about having to give my personal infomation.

We don't share your info, the airtable that stores the data is extremely controlled and only trusted people have access. but if you prefer to not fill, it's your choice and we respect:)

@vercel vercel bot temporarily deployed to Preview – sprig January 28, 2024 01:36 Inactive
@vercel vercel bot temporarily deployed to Preview – sprig January 28, 2024 01:39 Inactive
Copy link

Plagiarism Report

Game overlap report:

None detected

@LucasHT22 LucasHT22 merged commit 57b0355 into hackclub:main Jan 28, 2024
3 checks passed
LucasHT22 added a commit that referenced this pull request Jan 28, 2024
Copy link

Plagiarism Report

Game overlap report:

None detected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
submission Game submission
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants