Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple gallery fixes #1323

Merged
merged 9 commits into from
Dec 22, 2023
Merged

Conversation

grymmy
Copy link
Contributor

@grymmy grymmy commented Dec 21, 2023

  1. Load game content (code + images) from local (server-side) instead of github - WYSIWYG
  2. Fixes metadata issues resulting in 404's (all entries in metadata.json containing len > 0 caused 404's on client.
  3. Fixes client-side thumbnail caching (every character pressed in search bar would redownload ALL images every time)

Overall this makes the gallery load quicker and be snappier, far less network bandwidth utilized

…etadata issues resulting in 404's. Fix client-side thumbnail caching
Copy link

vercel bot commented Dec 21, 2023

@grymmy is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Dec 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sprig ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2023 2:27pm

Copy link
Contributor

@JosiasAurel JosiasAurel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vercel vercel bot temporarily deployed to Preview – sprig December 21, 2023 18:27 Inactive
@vercel vercel bot temporarily deployed to Preview – sprig December 21, 2023 18:33 Inactive
@vercel vercel bot temporarily deployed to Preview – sprig December 21, 2023 18:38 Inactive
@vercel vercel bot temporarily deployed to Preview – sprig December 21, 2023 19:06 Inactive
@vercel vercel bot temporarily deployed to Preview – sprig December 21, 2023 19:23 Inactive
@vercel vercel bot temporarily deployed to Preview – sprig December 22, 2023 14:15 Inactive
@vercel vercel bot temporarily deployed to Preview – sprig December 22, 2023 14:22 Inactive
@vercel vercel bot temporarily deployed to Preview – sprig December 22, 2023 14:27 Inactive
@grymmy grymmy merged commit d9bf92d into hackclub:main Dec 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants